Attachment 154257 Details for Bug 34305 – Bug 34305: Account for negative prices on acq details tab

[patch] Bug 34305: Account for negative prices on acq details tab

Bug-34305-Account-for-negative-prices-on-acq-detai.patch (text/plain), 2.07 KB, created by Marcel de Rooy on 2023-08-04 09:57:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-08-04 09:57:38 UTC

Size: 2.07 KB

patch

obsolete

>From f780523b669491596e3d7d01c027dd271a0124b3 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer@bsz-bw.de>
>Date: Tue, 18 Jul 2023 14:47:43 +0000
>Subject: [PATCH] Bug 34305: Account for negative prices on acq details tab
>Content-Type: text/plain; charset=utf-8
>
>The acquisition detail tab shows the estimated cost while
>the order is still pending and the actual price, once received.
>At least the tool tip on the table header row says so. This
>was not working correctly.
>
>To test:
>* Create a basket
>* Create a new order line with a negative list price (credit)
>* Close the basket
>* Verify that the price shows correctly in the acquisition details
>  tab on the record
>* Receive the order and enter a different negative actual price.
>* Reload detail view, verify it still shows the estimated price
>* Apply patch, restart_all
>* Verify now the correct actual price displays
>* Create another basket and order line
>* Verify while not yet received, it still shows the estimated price
>
>Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 2d7c7a1535..48860d975c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -889,7 +889,7 @@
>               [% END %]
>             </td>
>             <td>[% order.quantity | html %]</td>
>-            <td>[% IF ( order.unitprice_tax_included > 0 ) %][% order.unitprice_tax_included | $Price %][% ELSE %][% order.ecost_tax_included | $Price %][% END %]
>+            <td>[% IF ( order.orderstatus == "complete" ) %][% order.unitprice_tax_included | $Price %][% ELSE %][% order.ecost_tax_included | $Price %][% END %]
>             <td>[% order.order_internalnote | html %]</td>
>             <td>
>                 [% IF order.subscriptionid %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34305: 153610 | 153621 | 154257