Bugzilla – Attachment 15426 Details for
Bug 9484
userid not generated consistently (different editing pages)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9484: userid not generated consistently (different editing pages)
SIGNED-OFF-Bug-9484-userid-not-generated-consisten.patch (text/plain), 2.60 KB, created by
Bernardo Gonzalez Kriegel
on 2013-02-16 17:01:37 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9484: userid not generated consistently (different editing pages)
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2013-02-16 17:01:37 UTC
Size:
2.60 KB
patch
obsolete
>From f2ecbccfc6c32919cab884753427109ac353a607 Mon Sep 17 00:00:00 2001 >From: Adrien Saurat <adrien.saurat@biblibre.com> >Date: Thu, 24 Jan 2013 17:11:31 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 9484: userid not generated consistently > (different editing pages) > >When modifying a patron through different pages, the userid >generation does not behave always the same way; this patch >corrects this: >- when firstname and surname are present in the form, they >are used for the generation; >- if there are not in the form, the firstname and surname >in database are used instead. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Comment: Work as described. No errors. >Test >This patch lacks a test plan, so I do the following >1) New user, empty userid, autocompleted >2) Edit user, change userid, saved correctly >3) Edit user, main edit window, emptied userid, autocompleted >4) Edit user, Detail > Library use, emptied userid, not autocomplete (not even a dot) >5) Applied patch >6) Repeated 1-3, same behavior >7) Repeated 4), now autocompletes with same userid as 3) > >So, works as described. >No koha-qa errors. > >NOTE: It's impossible now to delete userid from interface. > >Off-topic: tried an userid in Arabic, works very well. >--- > members/memberentry.pl | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index f6d3e5e..3149bbe 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -254,7 +254,18 @@ $newdata{'country'} = $input->param('country') if defined($input->param('country > > #builds default userid > if ( (defined $newdata{'userid'}) && ($newdata{'userid'} eq '')){ >- $newdata{'userid'} = Generate_Userid($borrowernumber, $newdata{'firstname'}, $newdata{'surname'}); >+ if ( ( defined $newdata{'firstname'} ) && ( defined $newdata{'surname'} ) ) { >+ # Full page edit, firstname and surname input zones are present >+ $newdata{'userid'} = Generate_Userid( $borrowernumber, $newdata{'firstname'}, $newdata{'surname'} ); >+ } >+ elsif ( ( defined $data{'firstname'} ) && ( defined $data{'surname'} ) ) { >+ # Partial page edit (access through "Details"/"Library details" tab), firstname and surname input zones are not used >+ # Still, if the userid field is erased, we can create a new userid with available firstname and surname >+ $newdata{'userid'} = Generate_Userid( $borrowernumber, $data{'firstname'}, $data{'surname'} ); >+ } >+ else { >+ $newdata{'userid'} = $data{'userid'}; >+ } > } > > $debug and warn join "\t", map {"$_: $newdata{$_}"} qw(dateofbirth dateenrolled dateexpiry); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9484
:
14826
|
15426
|
16895