Attachment 154306 Details for Bug 34453 – Bug 34453: Update background of quick spine label pop-up

[patch] Bug 34453: Update background of quick spine label pop-up

Bug-34453-Update-background-of-quick-spine-label-p.patch (text/plain), 3.16 KB, created by Caroline Cyr La Rose on 2023-08-07 14:18:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caroline Cyr La Rose

Created: 2023-08-07 14:18:21 UTC

Size: 3.16 KB

patch

obsolete

>From a5d90f6a266386c0660e0bc1596b7c0bf5c314e4 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 4 Aug 2023 13:26:22 +0000
>Subject: [PATCH] Bug 34453: Update background of quick spine label pop-up
>
>This patch updates the quick spine label popup so that the footer uses
>the same markup as the recently updated Z39.50 popup window in
>cataloging.
>
>To test, apply the patch and rebuild the staff interface CSS.
>
>Go to Cataloging -> Quick spine label creator.
>
> - Test the form with both an existing barcode and a non-existent
>   barcode.
>   - In the pop-up window, confirm that the footer looks correct and
>     that the buttons in the footer, in both cases, work correctly.
>
>Signed-off-by: Sam Lau <samalau@gmail.com>
>Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>---
> .../en/modules/labels/spinelabel-print.tt     | 25 +++++++++++++------
> 1 file changed, 18 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt
>index 43875f1922c..d07eae00a8a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt
>@@ -17,18 +17,29 @@
> 	[% IF ( BarcodeNotFound ) %]
> 		<body id="labels_spinelabel-print" class="tools labels">
>             <div class="dialog message">The barcode [% Barcode | html %] was not found.</div>
>-            <div id="print_button" class="noprint">
>-                <button class="btn btn-default close-window">Close</button>
>-            </div>
>+
>+            <nav class="navbar navbar-default navbar-fixed-bottom noprint">
>+                <div class="container-fluid">
>+                    <fieldset class="action">
>+                        <button class="btn btn-default close-window">Close</button>
>+                    </fieldset>
>+                </div>
>+            </nav>
> 	[% ELSE %]
>             <body id="labels_spinelabel-print" class="tools labels">
>             <div id="spinelabel" class="[% Branches.GetLoggedInBranchcode | html %]" data-loggedinbranch="[% Branches.GetLoggedInBranchcode | html %]" data-homebranch="[% itemhomebranch | html %]" data-holdingbranch="[% itemholdingbranch | html %]">
>                 [% content | $raw %]
>             </div>
>-            <div id="print_button" class="noprint">
>-                <button class="btn btn-default print-label"><i class="fa fa-print"></i> Print this label</button>
>-                <button class="btn btn-default edit-label"><i class="fa fa-lock"></i> Edit this label</button>
>-            </div>
>+
>+            <nav class="navbar navbar-default navbar-fixed-bottom noprint">
>+                <div class="container-fluid">
>+                    <fieldset class="action">
>+                        <button class="btn btn-primary print-label"><i class="fa fa-print"></i> Print this label</button>
>+                        <button class="btn btn-default edit-label"><i class="fa fa-lock"></i> Edit this label</button>
>+                    </fieldset>
>+                </div>
>+            </nav>
>+
> 	[% END %]
> 
> [% Asset.js( "lib/jquery/jquery-3.6.0.min.js" ) | $raw %]
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 34453: 154277 | 154282 | 154306 | 156010