Bugzilla – Attachment 154347 Details for
Bug 29930
'cardnumber' overwritten with userid when not mapped (LDAP auth)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29930: Auth with LDAP: Update tag leads to unwanted updates
Bug-29930-Auth-with-LDAP-Update-tag-leads-to-unwan.patch (text/plain), 1.44 KB, created by
Alexander Wagner
on 2023-08-10 15:24:20 UTC
(
hide
)
Description:
Bug 29930: Auth with LDAP: Update tag leads to unwanted updates
Filename:
MIME Type:
Creator:
Alexander Wagner
Created:
2023-08-10 15:24:20 UTC
Size:
1.44 KB
patch
obsolete
>From fa6db2ef50723606eee015aa3f97cb574bf2bfca Mon Sep 17 00:00:00 2001 >From: "klaus.doch" <janik.hilser@systemli.org> >Date: Sun, 20 Feb 2022 18:14:31 +0100 >Subject: [PATCH] Bug 29930: Auth with LDAP: Update tag leads to unwanted > updates > >In the sub the userId was given, but the cardnumber was expected, therefore at every login the cardnumber changed to the userId. > >To test: >1. Login to the OPAC with an LDAP account that has a cardnumber which is different to the userId >2. Check the patron record's cardnumber. >3. The cardnumber should equal to the userId >4. Apply the patch. >5. Login to the OPAC with an LDAP account that has a cardnumber which is different to the userId >6. Check the patron record's cardnumber. >7. The cardnumber should be the same as before > >Signed-off-by: Alexander Wagner <alexander.wagner@desy.de> >--- > C4/Auth_with_ldap.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm >index f13dbdcf8e..edeb8b1208 100644 >--- a/C4/Auth_with_ldap.pm >+++ b/C4/Auth_with_ldap.pm >@@ -206,7 +206,7 @@ sub checkpw_ldap { > > if (( $borrowernumber and $config{update} ) or > (!$borrowernumber and $config{replicate}) ) { >- %borrower = ldap_entry_2_hash($userldapentry,$userid); >+ %borrower = ldap_entry_2_hash($userldapentry,$cardnumber); > #warn "checkpw_ldap received \%borrower w/ " . keys(%borrower), " keys: ", join(' ', keys %borrower), "\n"; > } > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29930
:
130926
|
154347
|
161078
|
161079
|
161085
|
161089
|
161090
|
161200
|
161201