Attachment 154386 Details for Bug 26916 – Bug 26916: Adjust unit tests

[patch] Bug 26916: Adjust unit tests

Bug-26916-Adjust-unit-tests.patch (text/plain), 1.78 KB, created by Nick Clemens (kidclamp) on 2023-08-11 17:41:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-08-11 17:41:06 UTC

Size: 1.78 KB

patch

obsolete

>From cc4a1344eae8a44efc7fc190fb88c7a366f7ff81 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 11 Aug 2023 17:40:28 +0000
>Subject: [PATCH] Bug 26916: Adjust unit tests
>
>---
> t/db_dependent/selenium/patrons_search.t | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/selenium/patrons_search.t b/t/db_dependent/selenium/patrons_search.t
>index 2b327a30e3..9ec3f2fbad 100755
>--- a/t/db_dependent/selenium/patrons_search.t
>+++ b/t/db_dependent/selenium/patrons_search.t
>@@ -165,7 +165,7 @@ subtest 'Search patrons' => sub {
>     C4::Context->set_preference('DefaultPatronSearchFields',"");
>     C4::Context->set_preference('DefaultPatronSearchMethod',"contains");
>     my $PatronsPerPage = 15;
>-    my $nb_standard_fields = 13;
>+    my $nb_standard_fields = 14; # Standard fields, plus one searchable attribute
>     C4::Context->set_preference('PatronsPerPage', $PatronsPerPage);
>     $driver->get( $base_url . "/members/members-home.pl" );
>     my @adv_options = $driver->find_elements('//select[@id="searchfieldstype"]/option');
>@@ -182,7 +182,6 @@ subtest 'Search patrons' => sub {
>     @filter_options = $driver->find_elements('//select[@id="searchfieldstype_filter"]/option');
>     is( scalar @filter_options, $nb_standard_fields, 'New filter option added when DefaultPatronSearchFields is populated with a field');
>     is( $filter_options[0]->get_value(), 'standard', 'Standard filter uses value "standard"');
>-    C4::Context->set_preference('DefaultPatronSearchFields',"firstname|initials|horses");
>     $driver->get( $base_url . "/members/members-home.pl" );
>     @adv_options = $driver->find_elements('//select[@id="searchfieldstype"]/option');
>     @filter_options = $driver->find_elements('//select[@id="searchfieldstype_filter"]/option');
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 26916: 154385 | 154386 | 154573 | 154574 | 154653 | 154654 | 158427 | 158428