Attachment 154404 Details for Bug 30846 – Bug 30846: (Fix) Unit tests

[patch] Bug 30846: (Fix) Unit tests

Bug-30846-Fix-Unit-tests.patch (text/plain), 1.36 KB, created by Hammat wele on 2023-08-14 15:20:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hammat wele

Created: 2023-08-14 15:20:23 UTC

Size: 1.36 KB

patch

obsolete

>From 24f2ff59a8c07288f4ab993aa03b1e7ab3e2d38b Mon Sep 17 00:00:00 2001
>From: Hammat Wele <hammat.wele@inlibro.com>
>Date: Mon, 14 Aug 2023 15:15:44 +0000
>Subject: [PATCH] Bug 30846: (Fix) Unit tests
>
>---
> t/db_dependent/Reserves.t | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t
>index e1d69ffce0..7e2d83e50e 100755
>--- a/t/db_dependent/Reserves.t
>+++ b/t/db_dependent/Reserves.t
>@@ -1484,10 +1484,20 @@ subtest 'IsAvailableForItemLevelRequest() tests' => sub {
>         "Item not available for item-level hold because no effective item type"
>     );
> 
>-    my $item_1 = $builder->build_sample_item({ notforloan => -1 });
>+    Koha::CirculationRules->set_rules(
>+        {
>+            categorycode => '*',
>+            itemtype     => '*',
>+            branchcode   => '*',
>+            rules        => {
>+                onshelfholds => 0,
>+            }
>+        }
>+    );
>+    my $item_1 = $builder->build_sample_item( { notforloan => -1 } );
>     ok(
>         C4::Reserves::IsAvailableForItemLevelRequest( $item_1, $patron ),
>-        "Item not available for item-level hold because no effective item type"
>+        "We can placing hold on item with negative not for loan values when 'On shelf holds allowed' is set to 'If any unavailable'"
>     );
>     $schema->storage->txn_rollback;
> };
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 30846: 145586 | 145660 | 147443 | 147444 | 151648 | 151649 | 153797 | 153798 | 154404