Attachment 154413 Details for Bug 34445 – Bug 34445: Set default budget in addorderiso2709.pl

[patch] Bug 34445: Set default budget in addorderiso2709.pl

Bug-34445-Set-default-budget-in-addorderiso2709pl.patch (text/plain), 1.34 KB, created by Lucas Gass (lukeg) on 2023-08-14 16:59:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-08-14 16:59:04 UTC

Size: 1.34 KB

patch

obsolete

>From a11ba105b3f4ed4dad0208149d050926c0c64c66 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Mon, 31 Jul 2023 09:48:18 +0000
>Subject: [PATCH] Bug 34445: Set default budget in addorderiso2709.pl
>
>This patch allows the default budget to be used as a fallback if no budget is selected. Currently the default budget is set using lines 129-133 but then is never used.
>
>Test plan:
>1) Apply patch
>2) restart_all
>3) Follow the steps from the bug description
>4) Order lines should be added properly
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> acqui/addorderiso2709.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl
>index fb31a8bcee..cba4c8cd56 100755
>--- a/acqui/addorderiso2709.pl
>+++ b/acqui/addorderiso2709.pl
>@@ -257,6 +257,7 @@ if ($op eq ""){
>             # Group orderlines from MarcItemFieldsToOrder
>             my $budget_hash;
>             for (my $i = 0; $i < $count; $i++) {
>+                $budget_codes[$i] = $budget_id if !$budget_codes[$i]; # Use default budget if no budget selected in the UI
>                 $budget_hash->{$budget_codes[$i]}->{quantity} += 1;
>                 $budget_hash->{$budget_codes[$i]}->{price} = $itemprices[$i];
>                 $budget_hash->{$budget_codes[$i]}->{replacementprice} = $replacementprices[$i];
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34445: 154084 | 154085 | 154413 | 154791 | 154795 | 154874