Attachment 15443 Details for Bug 9633 – [PASSED QA] Bug 9633 - Replace YUI button on the itemtypes administration page with Bootstrap

[patch] [PASSED QA] Bug 9633 - Replace YUI button on the itemtypes administration page with Bootstrap

PASSED-QA-Bug-9633---Replace-YUI-button-on-the-ite.patch (text/plain), 2.35 KB, created by Katrin Fischer on 2013-02-17 09:16:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2013-02-17 09:16:40 UTC

Size: 2.35 KB

patch

obsolete

>From 4fb8c707494842370c46e4e72bf3a2ea600a908e Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Sat, 2 Feb 2013 19:16:21 -0500
>Subject: [PATCH] [PASSED QA] Bug 9633 - Replace YUI button on the itemtypes
> administration page with Bootstrap
>
>This patch converts the toolbar on the itemtypes administration page to
>Bootstrap, replacing YUI button code with Bootstrap markup.
>
>Small unrelated edit: Button label text case correction.
>
>To test, view the itemtypes administration page and confirm that the
>'New item type' button looks correct and works correctly.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>
>Comment: Work and look correctly. No errors.
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Works nicely, no problems found.
>---
> .../prog/en/modules/admin/itemtypes.tt             |   26 +++-----------------
> 1 file changed, 4 insertions(+), 22 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
>index 30a3a85..7b6000c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
>@@ -127,27 +127,9 @@ Item types administration
> 	<div id="yui-main">
> 	<div class="yui-b">
> 	
>-[% IF ( else ) %]<div id="toolbar">
>-	<script type="text/javascript">
>-	//<![CDATA[
>-
>-	// prepare DOM for YUI Toolbar
>-
>-	 $(document).ready(function() {
>-	    yuiToolbar();
>-	 });
>-
>-	// YUI Toolbar Functions
>-
>-	function yuiToolbar() {
>-	    new YAHOO.widget.Button("newitemtype");
>-	}
>-
>-	//]]>
>-	</script>
>-	<ul class="toolbar">
>-    <li><a id="newitemtype" href="/cgi-bin/koha/admin/itemtypes.pl?op=add_form">New item type</a></li>
>-</ul></div>[% ELSE %]&nbsp;[% END %]
>+[% IF ( else ) %]<div id="toolbar" class="btn-toolbar">
>+    <a class="btn btn-small" id="newitemtype" href="/cgi-bin/koha/admin/itemtypes.pl?op=add_form"><i class="icon-plus"></i> New item type</a>
>+</div>[% END %]
> 
> [% IF ( add_form ) %]
>   [% IF ( itemtype ) %]
>@@ -254,7 +236,7 @@ Item types administration
>     </fieldset>
> 
>     <fieldset class="action">
>-      <input type="button" value="Save Changes" onclick="Check(this.form)" />
>+      <input type="button" value="Save changes" onclick="Check(this.form)" />
> 	  <a href="/cgi-bin/koha/admin/itemtypes.pl" class="cancel">Cancel</a>
>     </fieldset>
> </form>
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9633: 15391 | 15401 | 15443