Attachment 15444 Details for Bug 9646 – [PASSED QA] Bug 9646 - Replace YUI button on the printers administration page with Bootstrap

[patch] [PASSED QA] Bug 9646 - Replace YUI button on the printers administration page with Bootstrap

PASSED-QA-Bug-9646---Replace-YUI-button-on-the-pri.patch (text/plain), 2.32 KB, created by Katrin Fischer on 2013-02-17 09:23:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2013-02-17 09:23:23 UTC

Size: 2.32 KB

patch

obsolete

>From f927eca56c909d65c7117a1e323c1b5e0f700ab5 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Sun, 3 Feb 2013 08:43:16 -0500
>Subject: [PATCH] [PASSED QA] Bug 9646 - Replace YUI button on the printers
> administration page with Bootstrap
>
>This patch converts the toolbar on the printers administration page to
>Bootstrap, replacing YUI button code with Bootstrap markup.
>
>To test, view the printers administration page and confirm that the "New
>printer" button looks correct and works correctly.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>
>Comment: Works well. No errors.
>Off-topic: How do you access this page? I can't find a link
>(tested using .../cgi-bin/koha/admin/printers.pl)
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Works well, no problems found.
>Accessed printers page manually: /cgi-bin/koha/admin/printers.pl
>---
> .../prog/en/modules/admin/printers.tt              |   17 ++++-------------
> 1 file changed, 4 insertions(+), 13 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/printers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/printers.tt
>index 7dfb80b..6edc88f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/printers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/printers.tt
>@@ -145,7 +145,7 @@
>     	<form action="[% script_name %]" method="post">
> 			<input type="hidden" name="op" value="delete_confirmed" />
> 			<input type="hidden" name="searchfield" value="[% searchfield %]" />
>-			<input type="submit" value="Delete this Printer" />
>+			<input type="submit" value="Delete this printer" />
> 			</form> <form action="[% script_name %]" method="post">
> 				<input type="submit" value="Do not Delete" />
> 			</form>
>@@ -160,18 +160,9 @@
> 
> [% IF ( else ) %]
> 
>-<div id="toolbar">
>-	<script type="text/javascript">
>-	//<![CDATA[
>-	// prepare DOM for YUI Toolbar
>-	 $(document).ready(function() {
>-	    new YAHOO.widget.Button("newprinter");
>-	 });
>-	//]]>
>-	</script>
>-	<ul class="toolbar">
>-    <li><a id="newprinter" href="/cgi-bin/koha/admin/printers.pl?op=add_form">New printer</a></li>
>-</ul></div>
>+<div id="toolbar" class="btn-toolbar">
>+    <a class="btn btn-small" id="newprinter" href="/cgi-bin/koha/admin/printers.pl?op=add_form"><i class="icon-plus"></i> New printer</a>
>+</div>
> 
> <h2>Printers</h2>
> 	[% IF ( searchfield ) %]
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9646: 15415 | 15420 | 15444