Bugzilla – Attachment 154515 Details for
Bug 34024
REST API should not allow changing the pickup location on found holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34024: (QA follow-up) Allow pickup location changing for in transit holds
Bug-34024-QA-follow-up-Allow-pickup-location-chang.patch (text/plain), 1.72 KB, created by
Martin Renvoize (ashimema)
on 2023-08-17 10:21:15 UTC
(
hide
)
Description:
Bug 34024: (QA follow-up) Allow pickup location changing for in transit holds
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-08-17 10:21:15 UTC
Size:
1.72 KB
patch
obsolete
>From 73d614c1f059c763f82ad395a7604e1f0b327928 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 1 Aug 2023 16:40:03 -0300 >Subject: [PATCH] Bug 34024: (QA follow-up) Allow pickup location changing for > in transit holds > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/REST/V1/Holds.pm | 1 - > t/db_dependent/api/v1/holds.t | 4 ++-- > 2 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/Koha/REST/V1/Holds.pm b/Koha/REST/V1/Holds.pm >index 97a4cbd1b4..543de87a32 100644 >--- a/Koha/REST/V1/Holds.pm >+++ b/Koha/REST/V1/Holds.pm >@@ -537,7 +537,6 @@ sub update_pickup_location { > > my $error_code = > $hold->is_waiting ? 'hold_waiting' >- : $hold->is_in_transit ? 'hold_in_transit' > : $hold->is_in_processing ? 'hold_in_processing' > : undef; > >diff --git a/t/db_dependent/api/v1/holds.t b/t/db_dependent/api/v1/holds.t >index abb7f35f45..245e5e6a09 100755 >--- a/t/db_dependent/api/v1/holds.t >+++ b/t/db_dependent/api/v1/holds.t >@@ -1419,8 +1419,8 @@ subtest 'PUT /holds/{hold_id}/pickup_location tests' => sub { > > $t->put_ok( "//$userid:$password@/api/v1/holds/" > . $in_transit_hold->id >- . "/pickup_location" => json => { pickup_library_id => $library_2->branchcode } )->status_is(409) >- ->json_is( { error => q{Cannot change pickup location}, error_code => 'hold_in_transit' } ); >+ . "/pickup_location" => json => { pickup_library_id => $library_2->branchcode } )->status_is(200) >+ ->json_is( { pickup_library_id => $library_2->branchcode } ); > > $schema->storage->txn_rollback; > }; >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34024
:
154105
|
154106
|
154126
|
154127
|
154132
|
154513
|
154514
| 154515