Bugzilla – Attachment 154530 Details for
Bug 33428
Should only search in searchable patron attributes if searching in standard fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33428: (QA follow-up) Fix escaping in a split call
Bug-33428-QA-follow-up-Fix-escaping-in-a-split-cal.patch (text/plain), 1.23 KB, created by
Martin Renvoize (ashimema)
on 2023-08-17 10:55:14 UTC
(
hide
)
Description:
Bug 33428: (QA follow-up) Fix escaping in a split call
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-08-17 10:55:14 UTC
Size:
1.23 KB
patch
obsolete
>From 0cd9645cd9a736db6a70da590798228e607322d6 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 17 Aug 2023 11:41:47 +0100 >Subject: [PATCH] Bug 33428: (QA follow-up) Fix escaping in a split call > >We'd missed an escape case in one of the calls to .split for the pipe >delimited split operations. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >index cb03827e4f..884a430c10 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >@@ -576,7 +576,7 @@ function buildPatronSearchQuery(term, options) { > let pattern_subquery_and = []; > patterns.forEach(function (pattern, i) { > let pattern_subquery_or = []; >- search_fields.split('|').forEach(function (field, i) { >+ search_fields.split('\|').forEach(function (field, i) { > pattern_subquery_or.push( > { ["me." + field]: { 'like': leading_wildcard + pattern + '%' } } > ); >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33428
:
154352
|
154355
|
154367
|
154368
|
154528
|
154529
| 154530 |
154638