Attachment 154588 Details for Bug 34066 – Bug 34066: Datatable options don't fully translate on list of saved reports

[patch] Bug 34066: Datatable options don't fully translate on list of saved reports

Bug-34066-Datatable-options-dont-fully-translate-o.patch (text/plain), 2.09 KB, created by Victor Grousset/tuxayo on 2023-08-18 07:25:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2023-08-18 07:25:07 UTC

Size: 2.09 KB

patch

obsolete

>From 831c279b35eccce4c64e5621445ad15dbd98df7d Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 21 Jun 2023 13:30:57 +0000
>Subject: [PATCH] Bug 34066: Datatable options don't fully translate on list of
> saved reports
>
>This patch corrects the DataTable option for defining an alternate
>language string when no records are returned by a table filter. An
>obsolete version of the option name was breaking the existing custom
>option supplied by our datatables.js
>
>To test, apply the patch and go to Reports -> Use saved..
>
> - In the DataTable of existing reports, all the DataTable controls
>   should look correct.
> - In the filter field at the top of the table, enter a string which
>   will not be found. You should see a message, "No matching reports
>   found."
> - Install another language if necessary, and switch to that language.
> - The labels on all the DataTable controls should show the terms which
>   have been translated for that language.
>
>Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> .../prog/en/modules/reports/guided_reports_start.tt        | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 9a037da8cd..9da93ae83f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -1906,9 +1906,10 @@
>                     'bAutoWidth': false,
>                     'sPaginationType': 'full',
>                     'aaSorting': [[ 1, "asc" ]],
>-                    'oLanguage': {
>-                        'sZeroRecords': _("No matching reports found")
>-                    }
>+                    "language": {
>+                        "zeroRecords": _("No matching reports found")
>+                    },
>+
>                 }, table_settings);
> 
>                 $("#tabs a[data-toggle='tab']").on("shown.bs.tab", function (e) {
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 34066: 152484 | 152519 | 154322 | 154588