Attachment 154600 Details for Bug 23415 – Bug 23415: Add fine formatting

[patch] Bug 23415: Add fine formatting

Bug-23415-Add-fine-formatting.patch (text/plain), 1.54 KB, created by Biblibre Sandboxes on 2023-08-18 08:16:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Biblibre Sandboxes

Created: 2023-08-18 08:16:29 UTC

Size: 1.54 KB

patch

obsolete

>From 5778360319801be91662d1ab3c1d3269a6df5ce5 Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Wed, 28 Jun 2023 11:15:51 +0300
>Subject: [PATCH] Bug 23415: Add fine formatting
>
>To test:
>1. Find patron with checkouts and fines over allowed limit.
>2. Renew checkouts either from renew page or checkout list.
>=> Confirm that fines are formated correctly e.g. "The patron
>has a debt of 20.00" not like "The patron has a debt of 20."
>
>Signed-off-by: Veli-Matti <veli-matti.hakkinen@jyu.fi>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index 0ade5e6311..c01f264f46 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -918,8 +918,8 @@
>         [% UNLESS ( patron.borrowernumber ) %]window.onload=function(){ $('#findborrower').focus(); };[% END %]
> 
>         var amountlimit = "[% Koha.Preference('FineNoRenewals') | html %]";
>-        var fines = "[% fines | html %]";
>-        var MSG_CONFRIM_RENEW = _("The patron has a debt of %s.\n Are you sure you want to renew checkout(s)?").format(fines);
>+        var fines = "[% fines | $Price %]";
>+        var MSG_CONFRIM_RENEW = _("The patron has a debt of %s\nAre you sure you want to renew checkout(s)?").format(fines);
> 
>         // On-site checkout
>         function toggle_onsite_checkout(){
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 23415: 92039 | 92541 | 98442 | 98634 | 98996 | 98997 | 105893 | 105894 | 108392 | 109871 | 109872 | 109876 | 109880 | 116919 | 116920 | 116921 | 116922 | 118175 | 118176 | 118177 | 118178 | 118183 | 119300 | 119301 | 119302 | 119303 | 121472 | 139670 | 139671 | 139672 | 139673 | 139674 | 146415 | 148198 | 148199 | 148200 | 148201 | 148202 | 152776 | 152777 | 152778 | 152779 | 152780 | 152781 | 154595 | 154596 | 154597 | 154598 | 154599 | 154600 | 158302 | 158303 | 158304 | 158305 | 158306 | 158307 | 161964 | 161965 | 161966 | 161967 | 161968 | 161969 | 162171 | 162172 | 162173 | 162174 | 162175 | 162176 | 162177 | 162178 | 162179 | 162180 | 171620 | 171621 | 171622 | 171623 | 171983 | 171984 | 171985 | 171986 | 172906 | 172907 | 172908 | 172909 | 172910