Bugzilla – Attachment 154638 Details for
Bug 33428
Should only search in searchable patron attributes if searching in standard fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33428 (follow-up): Default to searching 'standard' fields
Bug-33428-follow-up-Default-to-searching-standard-.patch (text/plain), 1.60 KB, created by
Nick Clemens (kidclamp)
on 2023-08-18 11:19:24 UTC
(
hide
)
Description:
Bug 33428 (follow-up): Default to searching 'standard' fields
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-08-18 11:19:24 UTC
Size:
1.60 KB
patch
obsolete
>From d0f9651ba1cc166d22ddc13b848948d1aa8b6def Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 18 Aug 2023 11:16:44 +0000 >Subject: [PATCH] Bug 33428 (follow-up): Default to searching 'standard' fields > >Before this patch set, a search for patrons from article requests or >reserves would search the attributes by default. They were not considered >'standard' searches, however. > >This patch simply defaults to searching the 'standard' fields unless a value is passed > >To test: >1 - Apply other patches >2 - Have patrons with searchable attributes >3 - From a title, click the holds or artickle requests tab >4 - Search for the attribute values and confirm patrons are not returned >5 - Apply this patch >6 - Search again, patrons are now returned >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >index 8ea0b10db5a..92f4b2fc2fc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >@@ -321,7 +321,7 @@ > let filters = []; > > let search_type = $("#searchtype_filter").val() || "contains"; >- let search_fields = $("#searchfieldstype_filter").val(); >+ let search_fields = $("#searchfieldstype_filter").val() || "standard"; > let pattern = $("#search_patron_filter").val(); > > filters = buildPatronSearchQuery( >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33428
:
154352
|
154355
|
154367
|
154368
|
154528
|
154529
|
154530
| 154638