Attachment 154639 Details for Bug 34572 – Bug 34572: Simplify template logic around check-in input form

[patch] Bug 34572: Simplify template logic around check-in input form

Bug-34572-Simplify-template-logic-around-check-in-.patch (text/plain), 2.79 KB, created by PTFS Europe Sandboxes on 2023-08-18 11:22:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: PTFS Europe Sandboxes

Created: 2023-08-18 11:22:18 UTC

Size: 2.79 KB

patch

obsolete

>From 9f5f6d49fd1bf5d8ff2abd5c8c1a5fced73530d4 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 18 Aug 2023 07:40:16 +0000
>Subject: [PATCH] Bug 34572: Simplify template logic around check-in input form
>
>This patch makes a minor simplifying change to the check-in template
>around how to style the barcode input field in dropbox or fine-exempt
>mode.
>
>To test, apply the patch and go to Circulation.
>
>- If necessary, check some items out to patrons so that you have items
>  to check in.
>- Go to the check-in page and click the icon inside the barcode field to
>  expand the panel of options.
>- Check the "book drop mode" checkbox. The barcode field should now be
>  highlighted yellow.
>- Check in an item. When the page redisplays, the barcode field should
>  have the same highlighted style.
>
>- If necessary, enable the finesMode system preference.
>- On the check-in page, in the panel of options, check the "Forgive
>  overdue fines" checkbox. Test checking in again, confirming the same
>  style consistency in the barcode field.
>
>Signed-off-by: Inkeri <inkeri.hakulinen@helsinki.fi>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 0bcc733cf8..5bf309ecdd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -1085,12 +1085,10 @@
>                                 <div class="row">
>                                     <div class="col-sm-6">
>                                             <div class="form-control-group">
>-                                                [% IF ( exemptfine ) %]
>+                                                [% IF ( exemptfine || dropboxmode ) %]
>                                                     <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" type="text" />
>-                                                [% ELSIF ( dropboxmode ) %]
>-                                                    <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" />
>                                                 [% ELSE %]
>-                                                    <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus" />
>+                                                    <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus" type="text" />
>                                                 [% END %]
> 
>                                                 <div id="show-circ-settings">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34572: 154589 | 154639 | 154811