Attachment 154656 Details for Bug 27496 – Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers

[patch] Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers

Bug-27496-Accessibility-Navigation-buttons-are-poo.patch (text/plain), 3.65 KB, created by Lucas Gass (lukeg) on 2023-08-18 14:07:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-08-18 14:07:11 UTC

Size: 3.65 KB

patch

obsolete

>From 8e6112f02ad695a53328b3113d11812a425af416 Mon Sep 17 00:00:00 2001
>From: Kevin Carnes <kevin.carnes@ub.lu.se>
>Date: Fri, 18 Aug 2023 13:37:51 +0200
>Subject: [PATCH] Bug 27496: Accessibility: Navigation buttons are poorly
> described by screen readers
>
> This patch adds aria-haspopup and aria-expanded attributes to the language
> and welcome user buttons so that screen readers will know that they cause a
> popup menu to be displayed.
>
> To test:
> 1. Use an installation with at least 2 active languages
> 2. Log in the OPAC
> 3. Use a screen reader (e.g. ChromeVox in Chrome) and use the tab key to
> navigate to the language and welcome user buttons while noticing that
> they are described as "Button collapsed" and "Button", respectively
> 4. Alternatively, inspect the buttons and notice that they are missing
> aria-haspopup and aria-expanded attributes
> 5. Apply the patch
> 6. Observe that these buttons now are described as "Popup button collapsed"
> or that they contain the aria-haspopup and aria-expanded attributes like
> the lists button
> 7. Sign off
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc
>index c80d978837..de27ee097b 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc
>@@ -3,7 +3,7 @@
> <div id="header_langmenu">
> <ul class="navbar-nav">
> <li class="dropdown">
>- <a href="#" title="Switch languages" class="nav-link dropdown-toggle" id="langmenu" data-toggle="dropdown" role="button"> Languages </a>
>+ <a href="#" title="Switch languages" class="nav-link dropdown-toggle" id="langmenu" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"> Languages </a>
> <div aria-labelledby="langmenu" role="menu" class="dropdown-menu dropdown-menu-right">
> [% FOREACH languages_loo IN languages_loop %]
> [% IF ( languages_loo.group_enabled ) %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>index 8ea412792d..fd0a3f10d3 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>@@ -98,7 +98,7 @@
> <li class="nav-item dropdown">
> [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) %]
> [% IF ( loggedinusername ) %]
>- <a href="/cgi-bin/koha/opac-user.pl" class="dropdown-toggle" id="user-menu" data-toggle="dropdown" role="button">
>+ <a href="/cgi-bin/koha/opac-user.pl" class="dropdown-toggle" id="user-menu" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">
> 
> Welcome, [% INCLUDE 'patron-title.inc' patron = logged_in_user no_html = 1 %]
> </a>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 27496: 154650 | 154656 | 154810