Bugzilla – Attachment 154683 Details for
Bug 34307
Update plugin wrapper to use template wrapper for breadcrumbs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34307: (follow-up) Use template wrapper for title tag
Bug-34307-follow-up-Use-template-wrapper-for-title.patch (text/plain), 2.21 KB, created by
Victor Grousset/tuxayo
on 2023-08-21 15:23:50 UTC
(
hide
)
Description:
Bug 34307: (follow-up) Use template wrapper for title tag
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2023-08-21 15:23:50 UTC
Size:
2.21 KB
patch
obsolete
>From 3231a86f7006dbfced9332f93de20d9123e9aec2 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 21 Aug 2023 12:34:43 +0000 >Subject: [PATCH] Bug 34307: (follow-up) Use template wrapper for title tag > >This patch updates the title tag to use a wrapper too, since Bug 33906 >is in the process of getting fixed. > >The patch also removes an extra <span> tag: Only the translatable string >needs the span, not the entire line. > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > .../en/includes/wrapper-staff-tool-plugin.inc | 23 +++++++++++-------- > 1 file changed, 13 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/wrapper-staff-tool-plugin.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/wrapper-staff-tool-plugin.inc >index f1edb79495..cc25eebf6e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/wrapper-staff-tool-plugin.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/wrapper-staff-tool-plugin.inc >@@ -1,19 +1,22 @@ > [% USE raw %] >+[% PROCESS 'i18n.inc' %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] > [% IF ( ! method ) %] >-[% method = 'tool'; %] >+ [% method = 'tool'; %] > [% END %] >-<title> >- [% IF ( plugin_title ) %][% plugin_title | html %] › [% END %] >- Plugins › >+<title>[% FILTER collapse %] >+ [% IF ( plugin_title ) %] >+ [% plugin_title | html %] › >+ [% END %] >+ [% t("Plugins") | html %] › > [% IF ( method == 'tool' ) %] >- Tools >+ [% t("Tools") | html %] > [% ELSE %] >- Administration >- [% END %] >- › Koha >- </title> >+ [% t("Administration") | html %] >+ [% END %] › >+ [% t("Koha") | html %] >+ [% END %]</title> > [% INCLUDE 'doc-head-close.inc' %] > </head> > >@@ -35,7 +38,7 @@ > <a href="/cgi-bin/koha/plugins/plugins-home.pl">Plugins</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- <span>[% IF ( plugin_title ) %][% plugin_title | html %][% ELSE %]<span>Plugin</span>[% END %]</span> >+ [% IF ( plugin_title ) %][% plugin_title | html %][% ELSE %]<span>Plugin</span>[% END %] > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34307
:
153623
|
153624
|
154324
|
154673
|
154674
|
154678
|
154679
| 154683