Bugzilla – Attachment 154749 Details for
Bug 34331
Point of sale transaction history is showing the wrong register information
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34331: Use register from userenv if parameter not passed
Bug-34331-Use-register-from-userenv-if-parameter-n.patch (text/plain), 2.30 KB, created by
Katrin Fischer
on 2023-08-24 20:00:49 UTC
(
hide
)
Description:
Bug 34331: Use register from userenv if parameter not passed
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-08-24 20:00:49 UTC
Size:
2.30 KB
patch
obsolete
>From 666e004ab370fd98f4d40c06b52714b8182581ec Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 24 Aug 2023 12:22:23 +0000 >Subject: [PATCH] Bug 34331: Use register from userenv if parameter not passed > >To recreate: >1. Enable the "EnablePointofSale" syspref. >2. Set the "UseCashRegisters" syspref to use. >3. Create 3 new registers (Register A, B and C) with a float amount of $25. >4. Under POS, configure 3 new debit types (i.e. Copies, Earbuds, Friends Donation) >-- You can leave the default amounts blank, or add an amount if desired. >-- Set "Can be manually invoiced?" and "Can be sold?" >5. Under point of sale make a $5 sale of copies under Register A. >6. Under point of sale make a $10 sale of earbuds under Register B. >7. Under point of sale make a $100 sale of Friends Donation under Register C. >8. At circ/set-library.pl set your register to Register A. >9. Go back to POS and view the "Transaction history for Register A" - it shows the correct amount of $5 sold in copies. >10. Go back to circ/set-library.pl and change your register to Register B. >11. Go back to POS and view the "Transaction history for Register B" - it shows the incorrect transaction history. It is showing the transaction history for Register A. >12. Go back to circ/set-library.pl and change your register to Register C. >13. Go back to POS and view the "Transaction history for Register C" - it shows the incorrect transaction history. It is showing the transaction history for Register A. >14. Apply patch, repeat. The correct transactions should now show. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > pos/register.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/pos/register.pl b/pos/register.pl >index 8250b663a9..aa9f8fd029 100755 >--- a/pos/register.pl >+++ b/pos/register.pl >@@ -43,7 +43,7 @@ my $logged_in_user = Koha::Patrons->find($loggedinuser) or die "Not logged in"; > my $schema = Koha::Database->new->schema; > > my $library_id = C4::Context->userenv->{'branch'}; >-my $registerid = $input->param('registerid'); >+my $registerid = $input->param('registerid') // C4::Context->userenv->{'register_id'}; > my $registers = Koha::Cash::Registers->search( > { branch => $library_id, archived => 0 }, > { order_by => { '-asc' => 'name' } } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34331
:
154730
|
154736
| 154749