Bugzilla – Attachment 154798 Details for
Bug 34522
Suggestion for purchase displays wrong library in OPAC display if patron suggests for non-home library
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34522: Pass the suggestion branchcode, not the suggeter branchcode
Bug-34522-Pass-the-suggestion-branchcode-not-the-s.patch (text/plain), 1.90 KB, created by
David Nind
on 2023-08-25 10:37:14 UTC
(
hide
)
Description:
Bug 34522: Pass the suggestion branchcode, not the suggeter branchcode
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-08-25 10:37:14 UTC
Size:
1.90 KB
patch
obsolete
>From d4a9194cfa1de4a771135e15f00439500eb06fbd Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 11 Aug 2023 20:53:44 +0000 >Subject: [PATCH] Bug 34522: Pass the suggestion branchcode, not the suggeter > branchcode > >To test: >1. Turn on OPACViewOthersSuggestions >2. Log into OPAC as patron of Branch A >3. Make purchase suggestion for Branch B >4. Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A >5. View suggestion from staff client - See that it accurately reflects suggestion having been made for Branch B >6. Apply patch and try steps 2 - 5 again, this time you should see the proper branch. > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >index 9c21008640..c2d21651a6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >@@ -451,7 +451,7 @@ > <td> > [% IF suggestion.suggestedby %] > <span class="tdlabel">Suggested for:</span> >- [% Branches.GetName(suggestion.suggester.branchcode) | html %] >+ [% Branches.GetName(suggestion.branchcode) | html %] > [% END %] > </td> > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34522
:
154393
|
154496
| 154798