Bugzilla – Attachment 154806 Details for
Bug 34592
The patron search window, given just a sort field value, doesn't work
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34592: Patron Search filter fields needs to be at least an empty array
Bug-34592-Patron-Search-filter-fields-needs-to-be-.patch (text/plain), 1.78 KB, created by
Katrin Fischer
on 2023-08-25 12:10:46 UTC
(
hide
)
Description:
Bug 34592: Patron Search filter fields needs to be at least an empty array
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-08-25 12:10:46 UTC
Size:
1.78 KB
patch
obsolete
>From 8c6883cce86b12549562c908f2cc0f39103b6469 Mon Sep 17 00:00:00 2001 >From: Michael Hafen <michael.hafen@washk12.org> >Date: Thu, 24 Aug 2023 10:27:36 -0600 >Subject: [PATCH] Bug 34592: Patron Search filter fields needs to be at least > an empty array > >If buildPatronSearchQuery() doesn't return an empty array when it exits >early, then the code that adds the sort fields to the filters will fail. > >Test plan: > >- If there is not all ready a patron with a sort1 or sort2 value from > the bSort1 or bSort2 authorized values, add an authorized value if > necessary. >- Add a patron if necessary, and set the patrons sort field to the added > value. >- In Tools -> Patron card creator start a new card batch. >- Click on Add Patron(s) to open the patron search window. >- Pick the value in either the sort1 or sort2 drop down. >- Submit the page. The page will reload and there won't be results. >- Apply the patch, close the patron search window, clear the browser > cache, reload the "New patron card batch" page, and open the patron > search window again. >- Repeat the search. There will be results. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >index abb3193bd7..61869fc224 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >@@ -534,7 +534,7 @@ function buildPatronSearchQuery(term, options) { > > // Bail if no patterns > if (patterns.length == 0) { >- return; >+ return q; > } > > // Leading wildcard: If search_type option exists, we use that >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34592
:
154703
|
154742
|
154802
| 154806