Bugzilla – Attachment 154870 Details for
Bug 33537
Move domain limits from koha-conf to staff SMTP configuration
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33537: (QA follow-up) Use bootstrap modal native functions
Bug-33537-QA-follow-up-Use-bootstrap-modal-native-.patch (text/plain), 2.50 KB, created by
Marcel de Rooy
on 2023-08-28 07:38:58 UTC
(
hide
)
Description:
Bug 33537: (QA follow-up) Use bootstrap modal native functions
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-08-28 07:38:58 UTC
Size:
2.50 KB
patch
obsolete
>From 0b2bb44b77df5d7ea2cde326ca3d9945cf13a244 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 25 Aug 2023 11:56:08 +0000 >Subject: [PATCH] Bug 33537: (QA follow-up) Use bootstrap modal native > functions >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/js/domain_limits.js | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/domain_limits.js b/koha-tmpl/intranet-tmpl/prog/js/domain_limits.js >index 69ddb768d4..5ae049fb3a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/domain_limits.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/domain_limits.js >@@ -25,12 +25,6 @@ $(document).ready(function() { > api_delete( limit_id ); > } > }); >- $('#domain_limits_modal').on( 'keydown', function(ev) { >- if ( ev.which == 27 ) { // respond to escape key >- $('#domain_limits_modal').hide(); >- return false; >- } >- }); > $('#domain_limits_modal button.save').on( 'click', function() { > if ( !$('#domain_limits_modal form').get(0).checkValidity() ) return; // Do not return false here to allow validation. > var limit_id = $('#domain_limits_modal .modal-form').data('id'); >@@ -38,10 +32,6 @@ $(document).ready(function() { > if ( limit_id ) api_put(limit_id, row); else api_post(row); > return false; > }); >- $('#domain_limits_modal button.cancel').on( 'click', function() { >- $('#domain_limits_modal').hide(); >- return false; >- }); > }); > > function api_get (limit_id) { >@@ -81,7 +71,7 @@ function api_post (row) { > }).fail(function (xhr, status, error) { > status_message( 'post', xhr.status, row ); > }).always(function () { >- $('#domain_limits_modal').hide(); >+ $('#domain_limits_modal').modal('hide'); > });; > } > >@@ -97,7 +87,7 @@ function api_put (limit_id, row) { > }).fail(function (xhr, status, error) { > status_message( 'put', xhr.status, row ); > }).always(function () { >- $('#domain_limits_modal').hide(); >+ $('#domain_limits_modal').modal('hide'); > }); > } > >@@ -189,7 +179,7 @@ function start_modal (action, row) { > } else { > fill_modal_inputs(action, row); > } >- $('#domain_limits_modal').show().find('input')[0].focus(); >+ $('#domain_limits_modal').modal('show').find('input')[0].focus(); > } > > function init_table () { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33537
:
153351
|
153352
|
153353
|
153354
|
153355
|
153356
|
153357
|
153358
|
153359
|
153361
|
153362
|
153363
|
153364
|
154769
|
154770
|
154771
|
154772
|
154773
|
154774
|
154775
|
154776
|
154777
|
154778
|
154779
|
154818
|
154819
|
154820
|
154821
|
154822
|
154823
|
154824
|
154825
|
154826
|
154827
|
154828
|
154829
|
154830
|
154831
|
154832
|
154833
|
154869
|
154870
|
154871
|
154872
|
154873
|
157017
|
157018
|
157019
|
157020
|
157021
|
157022
|
157023
|
157024
|
157025
|
157026
|
157027
|
157028
|
157029
|
157030
|
157031
|
157032
|
157038
|
157039
|
157040
|
157041
|
157042
|
157043
|
157044
|
157045
|
157046
|
157047
|
157048