Attachment 154953 Details for Bug 34609 – Bug 34609: Add tests

[patch] Bug 34609: Add tests

Bug-34609-Add-tests.patch (text/plain), 1.74 KB, created by Pedro Amorim on 2023-08-30 13:13:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2023-08-30 13:13:25 UTC

Size: 1.74 KB

patch

obsolete

>From cc41b5f3673da96308a066c6329a296e8600debe Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Wed, 30 Aug 2023 13:13:04 +0000
>Subject: [PATCH] Bug 34609: Add tests
>
>---
> t/db_dependent/Koha/Old/Hold.t | 40 +++++++++++++++++++++++++++++++++-
> 1 file changed, 39 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Old/Hold.t b/t/db_dependent/Koha/Old/Hold.t
>index 91ed7a71c2..d62a3136fc 100755
>--- a/t/db_dependent/Koha/Old/Hold.t
>+++ b/t/db_dependent/Koha/Old/Hold.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 1;
>+use Test::More tests => 2;
> use Test::Exception;
> 
> use Koha::Database;
>@@ -80,3 +80,41 @@ subtest 'anonymize() tests' => sub {
> 
>     $schema->storage->txn_rollback;
> };
>+
>+subtest 'biblio() tests' => sub {
>+
>+    plan tests => 3;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $hold_1 = $builder->build_object(
>+        {
>+            class => 'Koha::Old::Holds',
>+            value => { biblionumber => undef }
>+        }
>+    );
>+
>+    is( $hold_1->biblio, undef, 'Old hold has no biblionumber, returns undef' );
>+
>+    my $hold_2 = $builder->build_object(
>+        {
>+            class => 'Koha::Old::Holds',
>+            value => { biblionumber => '' }
>+        }
>+    );
>+
>+    is( $hold_1->biblio, undef, 'Old hold has empty biblionumber, returns undef' );
>+
>+    my $biblio = $builder->build_object( { class => 'Koha::Biblios' } );
>+
>+    my $hold_3 = $builder->build_object(
>+        {
>+            class => 'Koha::Old::Holds',
>+            value => { biblionumber => $biblio->biblionumber }
>+        }
>+    );
>+
>+    is_deeply( $hold_3->biblio->unblessed, $biblio->unblessed, 'Old hold has a biblionumber, returns a biblio object' );
>+
>+    $schema->storage->txn_rollback;
>+};
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34609: 154738 | 154901 | 154952 | 154953 | 154954 | 154993 | 154994 | 154995