Attachment 15497 Details for Bug 9341 – Bug 9341: Problem with UNIMARC authors facets

[patch] Bug 9341: Problem with UNIMARC authors facets

Bug-9341-Problem-with-UNIMARC-authors-facets.patch (text/plain), 3.64 KB, created by Vitor Fernandes on 2013-02-18 10:43:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vitor Fernandes

Created: 2013-02-18 10:43:26 UTC

Size: 3.64 KB

patch

obsolete

>From 0550cf0c9ba70c1a87b9e50f86b22e9e9ae5459e Mon Sep 17 00:00:00 2001
>From: Vitor FERNANDES <vfernandes@keep.pt>
>Date: Mon, 18 Feb 2013 10:42:10 +0000
>Subject: [PATCH] Bug 9341: Problem with UNIMARC authors facets
>
>In UNIMARC installations the authors have a double comma separating the subfield a and the subfield b.
>
>Test plan:
>
>- After applying the patch do a search and check the double comma in authors facets.
>- Apply the patch
>- Do a new search
>- Check if authors facets as a double comma
>
>Sponsored-by: KEEP SOLUTIONS
>---
> C4/Koha.pm                                         |    2 +-
> installer/data/mysql/sysprefs.sql                  |    1 +
> installer/data/mysql/updatedatabase.pl             |    8 ++++++++
> .../en/modules/admin/preferences/searching.pref    |    4 ++++
> 4 files changed, 14 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Koha.pm b/C4/Koha.pm
>index 3892468..3109222 100644
>--- a/C4/Koha.pm
>+++ b/C4/Koha.pm
>@@ -706,7 +706,7 @@ sub getFacets {
>                 idx   => 'au',
>                 label => 'Authors',
>                 tags  => [ qw/ 700ab 701ab 702ab / ],
>-                sep   => ', ',
>+                sep   => C4::Context->preference("UNIMARCAuthorsFacetsSeparator"),
>             },
>             {
>                 idx   => 'se',
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index d5d15d7..ae02db6 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -406,3 +406,4 @@ INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('
> INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('NotesBlacklist','','List of notes fields that should not appear in the title notes/description separator of details',NULL,'free');
> INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('SCOUserCSS', '', NULL, 'Add CSS to be included in the SCO module in an embedded <style> tag.', 'free');
> INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('SCOUserJS', '', NULL, 'Define custom javascript for inclusion in the SCO module', 'free');
>+INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('UNIMARCAuthorsFacetsSeparator',', ', 'UNIMARC authors facets separator', NULL, 'short');
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 77265f4..041c9f6 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -6339,6 +6339,14 @@ if ( CheckVersion($DBversion) ) {
>    SetVersion ($DBversion);
> }
> 
>+$DBversion = "3.11.00.XXX";
>+if ( CheckVersion($DBversion) ) {
>+   $dbh->do("INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('UNIMARCAuthorsFacetsSeparator',', ', 'UNIMARC authors facets separator', NULL, 'short')");
>+   print "Upgrade to $DBversion done (Bug 9341: Problem with UNIMARC authors facets)\n";
>+   SetVersion ($DBversion);
>+}
>+
>+
> =head1 FUNCTIONS
> 
> =head2 TableExists($table)
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
>index 7b99173..cbcd078 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
>@@ -160,3 +160,7 @@ Searching:
>             - pref: FacetLabelTruncationLength
>               class: integer
>             - characters, in OPAC/staff interface.
>+        -
>+            - Use the following text as separator for UNIMARC authors facets
>+            - pref: UNIMARCAuthorsFacetsSeparator
>+              class: short
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9341: 14389 | 14413 | 14448 | 14449 | 15497 | 16279