Attachment 154979 Details for Bug 34666 – Bug 34666: Allow item_group to be null and still match

[patch] Bug 34666: Allow item_group to be null and still match

Bug-34666-Allow-itemgroup-to-be-null-and-still-mat.patch (text/plain), 1.40 KB, created by Nick Clemens (kidclamp) on 2023-08-30 19:04:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-08-30 19:04:46 UTC

Size: 1.40 KB

patch

obsolete

>From d2efee2948d67462020d4e7a0904f35bcfc9b1e8 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 30 Aug 2023 18:38:56 +0000
>Subject: [PATCH] Bug 34666: Allow item_group to be null and still match
>
>The current logic requires that the grop ids match, but this eliminates null matches
>from the group.
>
>The fallout essentially is that the queue won't be checked to fill holds in cases of title level matches
>where holds don't have an item group id. The queue checks the transport cost matrix while the check reserves
>check does not, so this may have an impact on holds costs and delivery times
>
>To test:
>0 - Apply unit test patch
>1 - prove -v t/db_dependent/Reserves.t
>2 - It fails
>3 - Apply this patch
>4 - prove -v t/db_dependent/Reserves.t
>5 - It passes!
>---
> C4/Reserves.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index fd8f7e58bd..160fc369c1 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -1782,7 +1782,7 @@ sub _Findgroupreserve {
>         AND hold_fill_targets.itemnumber = ?
>         AND reservedate <= DATE_ADD(NOW(),INTERVAL ? DAY)
>         AND suspend = 0
>-        AND reserves.item_group_id = item_group_items.item_group_id
>+        AND (reserves.item_group_id = item_group_items.item_group_id OR reserves.item_group_id IS NULL)
>         ORDER BY priority
>     };
>     $sth = $dbh->prepare($title_level_target_query);
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34666: 154978 | 154979 | 154980 | 154981 | 154983 | 154984 | 154985 | 154986 | 155221 | 155266 | 155267 | 155268 | 155269 | 155270