Bugzilla – Attachment 154992 Details for
Bug 33074
ReservesControlBranch not taken into account in opac-reserve.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33074: (QA follow-up) tidy code
Bug-33074-QA-follow-up-tidy-code.patch (text/plain), 1.43 KB, created by
Victor Grousset/tuxayo
on 2023-08-30 23:41:06 UTC
(
hide
)
Description:
Bug 33074: (QA follow-up) tidy code
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2023-08-30 23:41:06 UTC
Size:
1.43 KB
patch
obsolete
>From 3188faa2f6de13a757677e8eeb5d3a846196ba8b Mon Sep 17 00:00:00 2001 >From: Victor Grousset/tuxayo <victor@tuxayo.net> >Date: Thu, 31 Aug 2023 01:31:49 +0200 >Subject: [PATCH] Bug 33074: (QA follow-up) tidy code > >--- > opac/opac-reserve.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index 156c6058c4..cd453d3ba9 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -230,9 +230,9 @@ if ( $query->param('place_reserve') ) { > my $item = $itemNum ? Koha::Items->find( $itemNum ) : undef; > # When choosing a specific item, the default pickup library should be dictated by the default hold policy > if ( ! C4::Context->preference("OPACAllowUserToChooseBranch") && $item ) { >- my $type = $item->effective_itemtype; >- my $reserves_control_branch = GetReservesControlBranch($item->unblessed, $patron->unblessed); >- my $rule = GetBranchItemRule( $reserves_control_branch, $type ); >+ my $type = $item->effective_itemtype; >+ my $reserves_control_branch = GetReservesControlBranch( $item->unblessed, $patron->unblessed ); >+ my $rule = GetBranchItemRule( $reserves_control_branch, $type ); > > if ( $rule->{hold_fulfillment_policy} eq 'any' || $rule->{hold_fulfillment_policy} eq 'patrongroup' ) { > $branch = $patron->branchcode; >-- >2.42.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33074
:
147426
|
154543
|
154992
|
156094
|
156366