Bugzilla – Attachment 155013 Details for
Bug 34656
CartToShelf should not trigger RealTimeHoldsQueue
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34656: (QA follow-up) perltidy
Bug-34656-QA-follow-up-perltidy.patch (text/plain), 2.12 KB, created by
Emily Lamancusa (emlam)
on 2023-08-31 14:53:30 UTC
(
hide
)
Description:
Bug 34656: (QA follow-up) perltidy
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2023-08-31 14:53:30 UTC
Size:
2.12 KB
patch
obsolete
>From e73027b42138093c62b433b79d2b3639cc357e5c Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Thu, 31 Aug 2023 10:52:52 -0400 >Subject: [PATCH] Bug 34656: (QA follow-up) perltidy > >--- > t/db_dependent/Items.t | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index be63a071b8..3112745551 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -19,7 +19,8 @@ use Modern::Perl; > use Data::Dumper; > > use MARC::Record; >-use C4::Items qw( ModItemTransfer SearchItems AddItemFromMarc ModItemFromMarc get_hostitemnumbers_of Item2Marc ModDateLastSeen CartToShelf ); >+use C4::Items >+ qw( ModItemTransfer SearchItems AddItemFromMarc ModItemFromMarc get_hostitemnumbers_of Item2Marc ModDateLastSeen CartToShelf ); > use C4::Biblio qw( GetMarcFromKohaField AddBiblio ); > use C4::Circulation qw( AddIssue ); > use Koha::BackgroundJobs; >@@ -978,7 +979,7 @@ subtest 'CartToShelf test' => sub { > plan tests => 2; > > $schema->storage->txn_begin; >- my $dbh = C4::Context->dbh; >+ my $dbh = C4::Context->dbh; > my $builder = t::lib::TestBuilder->new; > > my $item = $builder->build_sample_item(); >@@ -989,17 +990,17 @@ subtest 'CartToShelf test' => sub { > > $item->discard_changes; > >- is( $item->location, 'BANANA', 'Item is correctly returned to permanent location'); >- >+ is( $item->location, 'BANANA', 'Item is correctly returned to permanent location' ); > > my $mock_RTHQ = Test::MockModule->new("Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue"); > $mock_RTHQ->mock( enqueue => sub { warn "RTHQ" } ); >- t::lib::Mocks::mock_preference('RealTimeHoldsQueue', '1'); >+ t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', '1' ); > >- $item->location('CART')->store({ skip_holds_queue => 1 }); >- warnings_are{ >+ $item->location('CART')->store( { skip_holds_queue => 1 } ); >+ warnings_are { > CartToShelf( $item->id ); >- } [], 'No RTHQ update triggered by CartToShelf'; >+ } >+ [], 'No RTHQ update triggered by CartToShelf'; > > $schema->storage->txn_rollback; > >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34656
:
154957
|
154958
|
155011
|
155012
|
155013
|
155207
|
155208
|
155209