Bugzilla – Attachment 155026 Details for
Bug 33766
Fix ambiguous form field in OPAC login form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33766: (follow-up) Change "cardnumber" to "card number"
Bug-33766-follow-up-Change-cardnumber-to-card-numb.patch (text/plain), 2.28 KB, created by
Owen Leonard
on 2023-08-31 16:20:43 UTC
(
hide
)
Description:
Bug 33766: (follow-up) Change "cardnumber" to "card number"
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2023-08-31 16:20:43 UTC
Size:
2.28 KB
patch
obsolete
>From 0493d36a78fee901c60691a598896c072492db21 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 31 Aug 2023 16:14:08 +0000 >Subject: [PATCH] Bug 33766: (follow-up) Change "cardnumber" to "card number" > >"Cardnumber' isn't really a word, and I think it comes off as >librarian-speak. This patch updates it to "Card number" >--- > .../prog/en/modules/admin/preferences/opac.pref | 6 +++--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >index 1c82d81d46..3358999929 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >@@ -174,11 +174,11 @@ OPAC: > - > - Use > - pref: OPACLoginLabelTextContent >- default: Cardnumber >+ default: Card number > choices: >- cardnumber: Cardnumber >+ cardnumber: Card number > username: Username >- cardnumberorusername: Cardnumber or username >+ cardnumberorusername: Card number or username > - "as the text content of the userid input field's label." > - > - pref: OPACShowMusicalInscripts >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc >index 3c1e12050a..976cfca066 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc >@@ -106,11 +106,11 @@ > > [% BLOCK login_label %] > [%- SET preference_value = Koha.Preference('OPACLoginLabelTextContent') %] >- [%- SET label = t("Cardnumber") %] >+ [%- SET label = t("Card number") %] > [%- IF preference_value == "username" %] > [%- SET label = t("Username") %] > [%- ELSIF preference_value == "cardnumberorusername" %] >- [%- SET label = t("Cardnumber or username") %] >+ [%- SET label = t("Card number or username") %] > [%- END %] > <label for="[% for | html %]">[% label | html %]:</label> > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33766
:
151416
|
151427
|
154566
|
154567
|
154570
|
155017
|
155018
|
155019
|
155022
|
155023
|
155024
|
155025
|
155026
|
157854
|
157855
|
157856
|
157857
|
157858
|
159342
|
159546
|
159547
|
159548
|
159549
|
159550
|
168600
|
168601
|
168602
|
168603
|
168604
|
168605
|
173757
|
173758
|
173759
|
173760
|
173761
|
173762
|
173972
|
173973
|
173974
|
173975
|
173976
|
173977
|
174037
|
174038
|
174039
|
174040
|
174041
|
174042