Bugzilla – Attachment 155122 Details for
Bug 34641
Novelist content does not display on OPAC detail page if NovelistSelectView is set to below
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34641: Fix Novelist display when NovelistSelectView is set to below
Bug-34641-Fix-Novelist-display-when-NovelistSelect.patch (text/plain), 2.26 KB, created by
Lucas Gass (lukeg)
on 2023-09-01 14:01:16 UTC
(
hide
)
Description:
Bug 34641: Fix Novelist display when NovelistSelectView is set to below
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2023-09-01 14:01:16 UTC
Size:
2.26 KB
patch
obsolete
>From cb33e872ea9a8326636a9ba2f16b0ebc8c939cc8 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 29 Aug 2023 15:45:39 +0000 >Subject: [PATCH] Bug 34641: Fix Novelist display when NovelistSelectView is > set to below > >To test: >1. Have Novelist credentials: NovelistSelectProfile, NovelistSelectPassword. >2. Enable NovelistSelectEnabled >3. Set NovelistSelectView to 'below holdings table'. >4. Find a record on the OPAC that would have Novelist content. It does > not display. >5. Set NovelistSelectView to any except 'below holdings table'. Notice it displays the content. >6. APPLY PATCH >7. Try steps 1 -5 again, this time when NovelistSelectView is set to > 'below' the content should properly display. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index db725b5814..c3784e8f41 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -958,10 +958,10 @@ > [% END %] > > [% IF ( NovelistSelectProfile && NovelistSelectView == 'below' && ( normalized_isbn || normalized_upc ) ) %] >- [% WRAPPER tab_panel tabname="NovelistSelect" %] >- <h2>Novelist Select</h2> >- <div data-novelist-novelistselect="[% IF normalized_isbn %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]"></div> >- [% END # /tab_panel#NovelistSelect %] >+ <span class="results_summary NovelistSelect" style="display:none;"> >+ <span class="label">Novelist Select: </span> >+ <div data-novelist-novelistselect=[% IF normalized_isbn %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]></div> >+ </span> > [% END %] > [% END # /WRAPPER tab_panels %] > [% END # /WRAPPER tabs#bibliodescriptions %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34641
:
154906
|
154911
|
155122
|
155193