Bugzilla – Attachment 155151 Details for
Bug 34694
OPAC bib record blows up with error 500
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34694: Only check for IsAvailableForItemLevelRequest if is authenticated
Bug-34694-Only-check-for-IsAvailableForItemLevelRe.patch (text/plain), 1.34 KB, created by
Tomás Cohen Arazi (tcohen)
on 2023-09-01 18:49:37 UTC
(
hide
)
Description:
Bug 34694: Only check for IsAvailableForItemLevelRequest if is authenticated
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2023-09-01 18:49:37 UTC
Size:
1.34 KB
patch
obsolete
>From 7c0b64d17bd742d23b238c5456bf51ac69c2ef95 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 1 Sep 2023 16:12:56 +0000 >Subject: [PATCH] Bug 34694: Only check for IsAvailableForItemLevelRequest if > is authenticated > >- Go to circulation rules and set On shelf holds allowed to If all unavailable >- Log out >- Visit a bib record on OPAC: >http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=76 >- Notice it blows up with error 500 >- Apply patch. Repeat > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > opac/opac-detail.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index b62de564586..5f5ce3013a7 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -682,7 +682,7 @@ else { > $item_info->{holding_library_info} = $opac_info_holding->content if $opac_info_holding; > $item_info->{home_library_info} = $opac_info_home->content if $opac_info_home; > >- $can_item_be_reserved = $can_item_be_reserved || IsAvailableForItemLevelRequest($item, $patron, undef); >+ $can_item_be_reserved = $can_item_be_reserved || $patron && IsAvailableForItemLevelRequest($item, $patron, undef); > > # get collection code description, too > my $ccode = $item->ccode; >-- >2.42.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34694
:
155130
|
155141
| 155151