Attachment 155182 Details for Bug 34257 – Bug 34257: Limit item types by branch in batchMod.pl

[patch] Bug 34257: Limit item types by branch in batchMod.pl

Bug-34257-Limit-item-types-by-branch-in-batchModpl.patch (text/plain), 1.39 KB, created by Victor Grousset/tuxayo on 2023-09-03 23:55:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2023-09-03 23:55:18 UTC

Size: 1.39 KB

patch

obsolete

>From 659a625cbf2aaf964ba1925beacb8421e3633f35 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 18 Aug 2023 14:45:14 +0000
>Subject: [PATCH] Bug 34257: Limit item types by branch in batchMod.pl
>
>To test:
>1. Go to Item types administration.
>2. Set some items types to be limited to a branch you are not logged in as.
>3. Find some items from the branch you are logged in at and go to Batch item modification.
>4. Add the barcodes and attempt to edit the item type to the one you limited in step 2.
>5. You can change these item types to ones that your branch should not be able to.
>6. Apply patch
>7. Try steps 4 -5 again but this time you should not see item types in the dropdown that are limited to other branches.
>
>Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> tools/batchMod.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tools/batchMod.pl b/tools/batchMod.pl
>index 6c252ff849..0a19b674a5 100755
>--- a/tools/batchMod.pl
>+++ b/tools/batchMod.pl
>@@ -283,6 +283,7 @@ if ($op eq "show"){
>             ignore_not_allowed_subfields => 1,
>             kohafields_to_ignore         => ['items.barcode'],
>             prefill_with_default_values => $use_default_values,
>+            branch_limit => C4::Context->userenv->{"branch"},
>             default_branches_empty      => 1,
>         }
>     );
>-- 
>2.42.0

Actions: View | Diff | Splinter Review

Attachments on bug 34257: 154660 | 154686 | 155182 | 155183