Bugzilla – Attachment 155206 Details for
Bug 34625
Search engine configuration tables header problem
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34625: Fix search engine configuration tables header problem
Bug-34625-Fix-search-engine-configuration-tables-h.patch (text/plain), 2.07 KB, created by
Victor Grousset/tuxayo
on 2023-09-04 23:45:19 UTC
(
hide
)
Description:
Bug 34625: Fix search engine configuration tables header problem
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2023-09-04 23:45:19 UTC
Size:
2.07 KB
patch
obsolete
>From 6976988810458d64cd98f938a82953238f65f9d7 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 28 Aug 2023 12:26:51 +0000 >Subject: [PATCH] Bug 34625: Fix search engine configuration tables header > problem > >This patch corrects the JavaScript which allows DataTables to be created >and destroyed based on which tab is clicked on the search engine >configuration page. When you click from one tab to the other, the >original tab's DataTable should be destroyed and the new tab's DataTable >initialized. > >To test, apply the patch and go to Administration -> Search engine >configuration (Elasticsearch) > >- The page should load with the "Search fields" tab enabled and the > DataTable initialized: Sorting and filtering should work. If you > scroll down the page the floating table header should be correct. >- Switch to the "Bibliographic records" tab. This table should have > filtering enabled, and the floating table header should work when you > scroll down the page. >- The same should be true for the "Authorities" tab. >- Return to the "Search fields" tab to confirm that the DataTable is > still working as expected. > >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js b/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js >index cf1faa9519..8bead3c010 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js >@@ -42,8 +42,8 @@ $(document).ready(function () { > tableInit( "", "search_fields"); > > $("a[data-toggle='tab']").on("shown.bs.tab", function (e) { >- var oldtabid = $(e.relatedTarget).data("tab"); >- var newtabid = $(e.target).data("tab"); >+ var oldtabid = $(e.relatedTarget).data("tabname"); >+ var newtabid = $(e.target).data("tabname"); > tableInit( oldtabid, newtabid ); > }); > >-- >2.42.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34625
:
154849
|
154880
|
154894
| 155206