Attachment 155256 Details for Bug 34725 – Bug 34725: Remove use of onclick for OPAC cart

[patch] Bug 34725: Remove use of onclick for OPAC cart

Bug-34725-Remove-use-of-onclick-for-OPAC-cart.patch (text/plain), 3.16 KB, created by David Cook on 2023-09-06 06:58:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2023-09-06 06:58:15 UTC

Size: 3.16 KB

patch

obsolete

>From 1909294b2acfd67825a7140e15e5ba78cc9b03bb Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Wed, 6 Sep 2023 06:57:15 +0000
>Subject: [PATCH] Bug 34725: Remove use of onclick for OPAC cart
>
>This patch moves the click handler in the OPAC cart from the inline HTML
>and out to an existing <script> element.
>
>Test plan:
>0. Apply the patch
>1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
>2. Add the results to the cart
>3. Click on the "Cart"
>4. One by one click on the title of each row
>5. Notice how the parent window changes to the detail record for that title
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
>index 30969b9013..4bfe59cca4 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
>@@ -303,7 +303,7 @@
>                                                 <input type="checkbox" class="cb" value="[% BIBLIO_RESULT.biblionumber | html %]" name="bib[% BIBLIO_RESULT.biblionumber | html %]" id="bib[% BIBLIO_RESULT.biblionumber | html %]">
>                                                 </td>
>                                             <td>
>-                                                <a href="#" onclick="openBiblio('[% PROCESS biblio_a_href biblionumber => BIBLIO_RESULT.biblionumber %]',[% BIBLIO_RESULT.biblionumber | html %])">[% INCLUDE 'biblio-title.inc' biblio=BIBLIO_RESULT %]</a>
>+                                                <a href="#" class="bib_opener" data-link="[% PROCESS biblio_a_href biblionumber => BIBLIO_RESULT.biblionumber %]" data-biblionumber="[% BIBLIO_RESULT.biblionumber | html %]">[% INCLUDE 'biblio-title.inc' biblio=BIBLIO_RESULT %]</a>
>                                                 
>                                                 <span class="Z3988" title="ctx_ver=Z39.88-2004&amp;rft_val_fmt=info%3Aofi%2Ffmt%3Akev%3Amtx%3Abook&amp;rft.au=[% BIBLIO_RESULT.author | html %]&amp;rft.btitle=[% BIBLIO_RESULT.title |url %]&amp;rft.date=[% BIBLIO_RESULT.publicationyear | html %]&amp;rft.tpages=[% BIBLIO_RESULT.item('size') | html %]&amp;rft.isbn=[% BIBLIO_RESULT.isbn |url %]&amp;rft.aucorp=&amp;rft.place=[% BIBLIO_RESULT.place | html %]&amp;rft.pub=[% BIBLIO_RESULT.publisher |url %]&amp;rft.edition=[% BIBLIO_RESULT.edition | html %]&amp;rft.series=[% BIBLIO_RESULT.series | html %]&amp;rft.genre="></span>
>                                                 [% IF ( TagsInputEnabled && loggedinusername ) %]
>@@ -411,6 +411,12 @@
>             [% END # / TagsInputEnabled && loggedinusername %]
> 
>             $(document).ready(function(){
>+                $("a.bib_opener").on('click',function(){
>+                    let link = this.dataset.link;
>+                    let biblionumber = this.dataset.biblionumber;
>+                    openBiblio(link,biblionumber)
>+                });
>+
>                 $(".brief").click(function(e){
>                     e.preventDefault();
>                     showLess();
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34725: 155256 | 155297 | 155757