Attachment 155380 Details for Bug 34377 – Bug 34377: (follow-up) Use patron-title include

[patch] Bug 34377: (follow-up) Use patron-title include

Bug-34377-follow-up-Use-patron-title-include.patch (text/plain), 2.96 KB, created by Martin Renvoize (ashimema) on 2023-09-08 09:11:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-09-08 09:11:36 UTC

Size: 2.96 KB

patch

obsolete

>From af539c19e0e40335b1441398086661df8c9c57d4 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 8 Sep 2023 09:48:40 +0100
>Subject: [PATCH] Bug 34377: (follow-up) Use patron-title include
>
>This switched the existing manual handling of patron title construction
>to use the accepted include method.
>---
> .../en/modules/members/accountline-details.tt    | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt
>index 6d35df4f27..dadc9c9eb6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt
>@@ -154,13 +154,7 @@
>                                 </td>
>                                 <td>
>                                     [% IF accountline.manager_id %]
>-                                        <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% accountline.manager_id | uri %]">
>-                                            [% IF accountline.manager.firstname %]
>-                                                [% accountline.manager.firstname | html %] [% accountline.manager.surname | html %]
>-                                            [% ELSE %]
>-                                                [% accountline.manager.surname | html %]
>-                                            [% END %]
>-                                        </a>
>+                                        [% INCLUDE 'patron-title.inc' patron => accountline.manager, hide_patron_infos_if_needed => 1, no_cardnumber => 1 %]
>                                     [% END %]
>                             </tr>
>                         </tbody>
>@@ -222,13 +216,7 @@
>                                         </td>
>                                         <td>
>                                             [% IF offset_accountline.manager_id %]
>-                                            <a href="moremember.pl?borrowernumber=[% offset_accountline.manager_id | uri %]">
>-                                                [% IF offset_accountline.manager.firstname %]
>-                                                    [% offset_accountline.manager.firstname | html %] [% offest_accountline.manager.surname | html %]
>-                                                [% ELSE %]
>-                                                    [% offset_accountline.manager.surname | html %]
>-                                                [% END %]
>-                                            </a>
>+                                                [% INCLUDE 'patron-title.inc' patron => offset_accountline.manager, hide_patron_infos_if_needed => 1, no_cardnumber => 1 %]
>                                             [% END %]
>                                         </td>
>                                         [%- ELSE -%]
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 34377: 155345 | 155379 | 155380 | 157234 | 157235