Bugzilla – Attachment 155393 Details for
Bug 34412
Inconsistencies in system preferences page titles, breadcrumbs, and header
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34412: (QA follow-up) Terminology updates
Bug-34412-QA-follow-up-Terminology-updates.patch (text/plain), 5.05 KB, created by
Owen Leonard
on 2023-09-08 10:50:42 UTC
(
hide
)
Description:
Bug 34412: (QA follow-up) Terminology updates
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2023-09-08 10:50:42 UTC
Size:
5.05 KB
patch
obsolete
>From 5542a27c4034bcf77a7b61ab8f81a18040fc7265 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 8 Sep 2023 10:42:24 +0000 >Subject: [PATCH] Bug 34412: (QA follow-up) Terminology updates > >- Use "system preference" instead of just "preference" >- Use "system_preference" as placeholder in translatable strings > >This patch also updates a few places where the placeholder i18n syntax >can be used for consistency. >--- > .../en/modules/admin/systempreferences.tt | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt >index be084497cf..cc1d9063a5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt >@@ -7,16 +7,16 @@ > <title>[% FILTER collapse %] > [% IF ( add_form ) %] > [% IF ( modify ) %] >- [% tx("Modify preference '{searchfield}'", { searchfield = searchfield }) | html %] >+ [% tx("Modify system preference '{system_preference}'", { system_preference = searchfield }) | html %] > [% ELSE %] >- [% t("New preference") | html %] >+ [% t("New system preference") | html %] > [% END %] › > [% END %] > [% IF ( delete_confirm ) %] >- [% tx("Confirm deletion of preference '{searchfield}'", { searchfield = searchfield }) | html %] › >+ [% tx("Confirm deletion of system preference '{system_preference}'", { system_preference = searchfield }) | html %] › > [% END %] > [% IF ( delete_confirmed ) %] >- [% t("Preference deleted") | html %] › >+ [% t("System preference deleted") | html %] › > [% END %] > [% t("Local use system preferences") | html %] › > [% t("Administration") | html %] › >@@ -45,9 +45,9 @@ > [% IF ( add_form ) %] > [% WRAPPER breadcrumb_item bc_active= 1 %] > [% IF ( modify ) %] >- <span>Modify preference '[% searchfield | html %]'</span> >+ [% tx("Modify system preference '{system_preference}'", { system_preference = searchfield }) | html %] > [% ELSE %] >- <span>New preference</span> >+ <span>New system preference</span> > [% END %] > [% END %] > [% END %] >@@ -57,13 +57,13 @@ > <a href="/cgi-bin/koha/admin/systempreferences.pl?op=add_form&searchfield=[% searchfield | uri %]">[% searchfield | html %]</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- <span>Confirm deletion of preference '[% searchfield | html %]'</span> >+ [% tx("Confirm deletion of system preference '{system_preference}'", { system_preference = searchfield }) | html %] > [% END %] > [% END %] > > [% IF ( delete_confirmed ) %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- <span>Preference deleted</span> >+ <span>System preference deleted</span> > [% END %] > [% END %] > >@@ -83,7 +83,7 @@ > [% IF ( add_form ) %] > <h1> > [% IF ( modify ) %] >- [% tx("Modify preference '{searchfield}'", { searchfield = searchfield }) | html %] >+ [% tx("Modify system preference '{searchfield}'", { searchfield = searchfield }) | html %] > [% ELSE %] > New local use system preference > [% END %] >@@ -95,7 +95,7 @@ > <form action="[% script_name | html %]" name="Aform" method="post"> > [% END %] > <fieldset class="rows"> >- <legend class="sr-only">Preference details</legend> >+ <legend class="sr-only">System preference details</legend> > <ol> > <li><label for="explanation">Explanation: </label><input type="text" name="explanation" id="explanation" size="60" value="[% explanation | html %]" /><input type="hidden" name="op" value="add_validate" /></li> > <li>[% IF ( searchfield ) %]<span class="label">Variable: </span>[% searchfield | html %]<input type="hidden" name="variable" value="[% searchfield | html %]" /> >@@ -267,7 +267,7 @@ > > [% IF ( delete_confirm ) %] > <div class="dialog alert"> >- <h1>Confirm deletion of [% searchfield | html %]?</h1> >+ <h1>[% tx("Confirm deletion of system preference '{system_preference}'?", { system_preference = searchfield }) | html %]</h1> > <table> > <tr> > <th>Variable name:</th> >@@ -302,7 +302,7 @@ > [% IF ( else ) %] > > <div id="toolbar" class="btn-toolbar"> >- <a class="btn btn-default" id="newstopword" href="[% script_name | url %]?op=add_form"><i class="fa fa-plus"></i> New preference</a> >+ <a class="btn btn-default" id="newstopword" href="[% script_name | url %]?op=add_form"><i class="fa fa-plus"></i> New system preference</a> > </div> > > [% IF ( tab != 'local_use' ) %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34412
:
155233
|
155250
|
155262
|
155393
|
155401
|
155402
|
155403