Bugzilla – Attachment 155402 Details for
Bug 34412
Inconsistencies in system preferences page titles, breadcrumbs, and header
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34412: (follow-up) Clarify page heading, remove unused markup
Bug-34412-follow-up-Clarify-page-heading-remove-un.patch (text/plain), 3.01 KB, created by
Katrin Fischer
on 2023-09-08 11:15:51 UTC
(
hide
)
Description:
Bug 34412: (follow-up) Clarify page heading, remove unused markup
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-09-08 11:15:51 UTC
Size:
3.01 KB
patch
obsolete
>From c14b85564ed81a130d191e1738f73bc7ea61ff93 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 6 Sep 2023 10:53:55 +0000 >Subject: [PATCH] Bug 34412: (follow-up) Clarify page heading, remove unused > markup > >This patch updates the heading for the "modify" view so that it includes >the name of the preference being modified. > >The patch also removes markup related to the "add_validate" >state--a view confirming that a preference has been added--because that >view doesn't exist. > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > .../en/modules/admin/systempreferences.tt | 23 +++---------------- > 1 file changed, 3 insertions(+), 20 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt >index 8d2deedd0c..be084497cf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt >@@ -12,9 +12,6 @@ > [% t("New preference") | html %] > [% END %] › > [% END %] >- [% IF ( add_validate ) %] >- [% t("Preference added") | html %] › >- [% END %] > [% IF ( delete_confirm ) %] > [% tx("Confirm deletion of preference '{searchfield}'", { searchfield = searchfield }) | html %] › > [% END %] >@@ -39,7 +36,7 @@ > <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> > [% END %] > >- [% IF ( add_form || add_validate || delete_confirm || delete_confirmed ) %] >+ [% IF ( add_form || delete_confirm || delete_confirmed ) %] > [% WRAPPER breadcrumb_item %] > <a href="/cgi-bin/koha/admin/systempreferences.pl">Local use system preferences</a> > [% END %] >@@ -55,12 +52,6 @@ > [% END %] > [% END %] > >- [% IF ( add_validate ) %] >- [% WRAPPER breadcrumb_item bc_active= 1 %] >- <span>Data added</span> >- [% END %] >- [% END %] >- > [% IF ( delete_confirm ) %] > [% WRAPPER breadcrumb_item %] > <a href="/cgi-bin/koha/admin/systempreferences.pl?op=add_form&searchfield=[% searchfield | uri %]">[% searchfield | html %]</a> >@@ -92,7 +83,7 @@ > [% IF ( add_form ) %] > <h1> > [% IF ( modify ) %] >- Modify a local use system preference >+ [% tx("Modify preference '{searchfield}'", { searchfield = searchfield }) | html %] > [% ELSE %] > New local use system preference > [% END %] >@@ -273,15 +264,7 @@ > > </form> > [% END %] >- >- [% IF ( add_validate ) %] >- <h1>Data recorded</h1> >- >- <form action="[% script_name | html %]" method="post"> >- <input type="submit" class="btn btn-primary" value="OK" /> >- </form> >- [% END %] >- >+ > [% IF ( delete_confirm ) %] > <div class="dialog alert"> > <h1>Confirm deletion of [% searchfield | html %]?</h1> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34412
:
155233
|
155250
|
155262
|
155393
|
155401
| 155402 |
155403