Bugzilla – Attachment 155481 Details for
Bug 34731
C4::Letters::SendQueuedMessages can be triggered with an undef message_id
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34731: (follow-up) Fix conditional variable declaration
Bug-34731-follow-up-Fix-conditional-variable-decla.patch (text/plain), 989 bytes, created by
Martin Renvoize (ashimema)
on 2023-09-11 11:53:26 UTC
(
hide
)
Description:
Bug 34731: (follow-up) Fix conditional variable declaration
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-09-11 11:53:26 UTC
Size:
989 bytes
patch
obsolete
>From f9923fc1a616ffd8824831ab8cb51096a4c5c515 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 11 Sep 2023 12:47:48 +0100 >Subject: [PATCH] Bug 34731: (follow-up) Fix conditional variable declaration > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Patron/Password/Recovery.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/Patron/Password/Recovery.pm b/Koha/Patron/Password/Recovery.pm >index 879058488e..f18b235c27 100644 >--- a/Koha/Patron/Password/Recovery.pm >+++ b/Koha/Patron/Password/Recovery.pm >@@ -158,7 +158,8 @@ sub SendPasswordRecoveryEmail { > } > ); > >- my $num_letters_attempted = C4::Letters::SendQueuedMessages( { message_id => $message_id } ) if $message_id; >+ my $num_letters_attempted = 0; >+ $num_letters_attempted = C4::Letters::SendQueuedMessages( { message_id => $message_id } ) if $message_id; > > return ($num_letters_attempted > 0); > } >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34731
:
155325
|
155326
|
155327
|
155459
|
155460
|
155461
|
155478
|
155479
|
155480
|
155481
|
158178
|
158179
|
158180