Bugzilla – Attachment 155493 Details for
Bug 34223
ILL status filter does not load immediately after selecting a backend filter
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34223: (follow-up) Ensure consistent ordering of statuses
Bug-34223-follow-up-Ensure-consistent-ordering-of-.patch (text/plain), 1.42 KB, created by
Martin Renvoize (ashimema)
on 2023-09-11 13:53:09 UTC
(
hide
)
Description:
Bug 34223: (follow-up) Ensure consistent ordering of statuses
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-09-11 13:53:09 UTC
Size:
1.42 KB
patch
obsolete
>From f8b37f9f12abb2900345d23571776ca92de02ee3 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 11 Sep 2023 14:50:43 +0100 >Subject: [PATCH] Bug 34223: (follow-up) Ensure consistent ordering of statuses > >This patch adds an order_by clause to ensure consistent ordering of the >returned status and status_alias statuses from the database between >MySQL 8 and other DB engines. > >This fixes the failing tests introducd in bug 34223. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Illbackend.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/Koha/Illbackend.pm b/Koha/Illbackend.pm >index df29e970a5..ab31d05495 100644 >--- a/Koha/Illbackend.pm >+++ b/Koha/Illbackend.pm >@@ -61,6 +61,7 @@ sub existing_statuses { > select => [ 'status', \'MAX(illrequest_id)', 'backend' ], > as => [qw/ status illrequest_id backend /], > group_by => [qw/status backend/], >+ order_by => [qw/status backend/], > } > ); > while ( my $request = $ill_requests->next ) { >@@ -83,6 +84,7 @@ sub existing_statuses { > select => [ 'status_alias', \'MAX(illrequest_id)', 'backend' ], > as => [qw/ status_alias illrequest_id backend /], > group_by => [qw/status_alias backend/], >+ order_by => [qw/status_alias backend/], > } > ); > while ( my $request = $ill_requests->next ) { >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34223
:
153289
|
153953
|
153956
|
153957
|
153961
|
153962
|
153963
|
153968
|
153973
|
153978
|
153979
|
153980
|
153981
|
153989
|
153990
|
154026
|
154027
|
154028
|
154029
|
154030
|
154031
|
154032
|
154033
|
154068
|
154069
|
154070
|
154071
|
155280
| 155493