Bugzilla – Attachment 155551 Details for
Bug 34149
Syndetics cover images don't load in staff interface detail page if other images services are enabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34149: Let Syndetics images show when Amazon returns 1px images
Bug-34149-Let-Syndetics-images-show-when-Amazon-re.patch (text/plain), 1.66 KB, created by
Biblibre Sandboxes
on 2023-09-12 14:21:23 UTC
(
hide
)
Description:
Bug 34149: Let Syndetics images show when Amazon returns 1px images
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2023-09-12 14:21:23 UTC
Size:
1.66 KB
patch
obsolete
>From 96fe679d053d1fb0e72848950f872d4d3b62c387 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 10 Aug 2023 17:31:10 +0000 >Subject: [PATCH] Bug 34149: Let Syndetics images show when Amazon returns 1px > images > >1. Turn on Syndetics >2. Set AmazonCoverImages to show >3. Go to a record detail page that has a Syndetics image but no Amazon image. In KTD I am using bib 181. >4. The image never loads. >5. Apply patch >6. Try again, the image should load. >7. Try records that have both Amazon and Syndetics images making sure it loads correctly in the lightbox. > >Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 95ceb7a0e1..1820765b74 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -1509,6 +1509,9 @@ > } > } else if ( div.attr("id") == "syndetics-bookcoverimg" ){ > lightbox_descriptions.push(_("Syndetics cover image (<a href='%s'>see the original image</a>)").format($(img).data('link'))); >+ if ( $('#amazon-bookcoverimg').length === 0 ) { >+ div.show(); >+ } > } > else if( div.hasClass("coce-coverimg" ) ){ > // Identify which service's image is being loaded by Coce >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34149
:
154349
|
155551
|
155768
|
155769