Attachment 155554 Details for Bug 34619 – Bug 34619: Show debug mode column in list of SMTP servers

[patch] Bug 34619: Show debug mode column in list of SMTP servers

Bug-34619-Show-debug-mode-column-in-list-of-SMTP-s.patch (text/plain), 2.47 KB, created by Emily-Rose Francoeur on 2023-09-12 14:35:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emily-Rose Francoeur

Created: 2023-09-12 14:35:16 UTC

Size: 2.47 KB

patch

obsolete

>From 7fa0fe8f5be9eb08c770a9c208c4098d371dd49f Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 28 Aug 2023 12:49:43 +0000
>Subject: [PATCH] Bug 34619: Show debug mode column in list of SMTP servers
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch adds a column to the table of SMTP servers which shows
>whether debug mode is on or off. This information was previously only
>conveyed through the color of the text in the table row.
>
>To test, apply the patch and go to Administration -> SMTP servers.
>
>- If necessary, add one or more SMTP servers so that there are more than
>  one: At least one with debug mode on, at least one with debug mode
>  off.
>- In the table listing SMTP servers you should see a column for "Debug
>  mode," where the rows indicate "On" or "Off."
>- Each row which is highlighted in red should show "On" for debug mode.
>
>Signed-off-by: Ãmily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
>---
> .../prog/en/modules/admin/smtp_servers.tt           | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
>index beefae3859..76e27e39ab 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
>@@ -261,6 +261,7 @@
>                         <th>Timeout (secs)</th>
>                         <th>SSL</th>
>                         <th>Authenticated</th>
>+                        <th>Debug mode</th>
>                         <th>Is default</th>
>                         <th data-class-name="actions noExport">Actions</th>
>                     </tr>
>@@ -394,6 +395,18 @@
>                         "searchable": false,
>                         "orderable": false
>                     },
>+                    {
>+                        "data": function( row, type, val, meta ) {
>+                            if ( row.debug ) {
>+                                return _("On");
>+                            }
>+                            else {
>+                                return _("Off");
>+                            }
>+                        },
>+                        "searchable": false,
>+                        "orderable": false
>+                    },
>                     {
>                         "data": function( row, type, val, meta ) {
>                             if ( row.is_default ) {
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 34619: 154884 | 155554 | 156407