Attachment 155625 Details for Bug 34552 – Bug 34552: Don't exclude payments with no status

[patch] Bug 34552: Don't exclude payments with no status

Bug-34552-Dont-exclude-payments-with-no-status.patch (text/plain), 1.43 KB, created by ByWater Sandboxes on 2023-09-14 16:48:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2023-09-14 16:48:20 UTC

Size: 1.43 KB

patch

obsolete

>From 29c3277c3189884162620a6d40d9f8d383119d53 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 25 Aug 2023 15:51:12 +0000
>Subject: [PATCH] Bug 34552: Don't exclude payments with no status
>
>Bug 29664 removed payments with a void status, however, the query also
>removed any payments with no status set
>
>Test Plan:
>1 - Set up your cash registers and enable POS and add a debit type that is able to be sold
>2 - Take 2 payments via POS
>3 - Void one payment
>4 - Go to Reports->Statistics wizards->Cash register
>4) Verify neither shows for the "All payments to the library" and
>   "Payment" transaction type filters
>5) Apply this patch
>6) Restart all the things!
>7) Verify the non-voided fee shows for the "All payments to the library" and
>   "Payment" transaction type filters and the voided fee does not
>
>Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
>---
> reports/cash_register_stats.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/reports/cash_register_stats.pl b/reports/cash_register_stats.pl
>index e88a5d7ab5..1dde63b114 100755
>--- a/reports/cash_register_stats.pl
>+++ b/reports/cash_register_stats.pl
>@@ -83,7 +83,7 @@ if ($do_it) {
>     }
> 
>     if ( $transaction_type eq 'PAYMENT' || $transaction_type eq 'ACT' ) {
>-        $whereTType .= q{ AND status != 'VOID' };
>+        $whereTType .= q{ AND (status != 'VOID' OR status IS NULL)  };
>     }
> 
>     my $whereBranchCode = q{};
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34552: 154834 | 155625 | 155756