Bugzilla – Attachment 155640 Details for
Bug 34728
HTML notices should not be pre-formatted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34728: (QA follow-up) Remove o modifier, bit more compact
Bug-34728-QA-follow-up-Remove-o-modifier-bit-more-.patch (text/plain), 1.17 KB, created by
Marcel de Rooy
on 2023-09-15 07:05:17 UTC
(
hide
)
Description:
Bug 34728: (QA follow-up) Remove o modifier, bit more compact
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-09-15 07:05:17 UTC
Size:
1.17 KB
patch
obsolete
>From 04949aa72db21f4321604aca5638718ed640fe23 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 15 Sep 2023 07:01:24 +0000 >Subject: [PATCH] Bug 34728: (QA follow-up) Remove o modifier, bit more compact >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > misc/cronjobs/gather_print_notices.pl | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/misc/cronjobs/gather_print_notices.pl b/misc/cronjobs/gather_print_notices.pl >index d2bf8fc874..9e4cd44f0a 100755 >--- a/misc/cronjobs/gather_print_notices.pl >+++ b/misc/cronjobs/gather_print_notices.pl >@@ -214,10 +214,8 @@ sub generate_html { > C4::Templates::gettemplate( 'batch/print-notices.tt', 'intranet', > CGI->new ); > >- foreach my $message (@{ $messages }) { >- my $content_type = $message->{'content_type'} || 'text/plain; charset="UTF-8"'; >- my $is_html = $content_type =~ m/html/io; >- $message->{'is_html'} = $is_html; >+ foreach my $message (@$messages) { >+ $message->{is_html} = $message->{content_type} && $message->{content_type} =~ /html/i; > } > > $template->param( >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34728
:
155263
|
155264
|
155265
|
155599
|
155639
| 155640