Attachment 155703 Details for Bug 33958 – Bug 33958: Add tests

[patch] Bug 33958: Add tests

Bug-33958-Add-tests.patch (text/plain), 1.31 KB, created by Kyle M Hall (khall) on 2023-09-15 17:01:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-09-15 17:01:39 UTC

Size: 1.31 KB

patch

obsolete

>From d07806bed8bcac80e67da64604ea0f8bb86dd253 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 8 Jun 2023 14:14:43 +0200
>Subject: [PATCH] Bug 33958: Add tests
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/db_dependent/Koha/Biblio.t | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t
>index 6895ea5bfa4..d1180edd503 100755
>--- a/t/db_dependent/Koha/Biblio.t
>+++ b/t/db_dependent/Koha/Biblio.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 28;
>+use Test::More tests => 29;
> use Test::Exception;
> use Test::Warn;
> 
>@@ -1150,6 +1150,18 @@ subtest 'normalized_upc' => sub {
>     );
> };
> 
>+subtest 'normalized_oclc' => sub {
>+    plan tests => 1;
>+
>+    # We will move the tests from GetNormalizedOCLC here when it will get replaced
>+    # Note that only a single test exist and it's not really meaningful...
>+    my $biblio = $builder->build_sample_biblio();
>+    is(
>+        $biblio->normalized_oclc, C4::Koha::GetNormalizedOCLCNumber( $biblio->metadata->record ),
>+        'normalized_oclc is a wrapper around C4::Koha::GetNormalizedOCLCNumber'
>+    );
>+};
>+
> subtest 'ratings' => sub {
>     plan tests => 1;
>     # See t/db_dependent/Koha/Ratings.t
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33958: 152175 | 152176 | 155703 | 155704 | 155705 | 156214 | 156215 | 156216