Attachment 155744 Details for Bug 34409 – Bug 34409: Fix inconsistencies in Audio alerts headers

[patch] Bug 34409: Fix inconsistencies in Audio alerts headers

Bug-34409-Fix-inconsistencies-in-Audio-alerts-head.patch (text/plain), 2.15 KB, created by Katrin Fischer on 2023-09-17 12:57:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-09-17 12:57:35 UTC

Size: 2.15 KB

patch

obsolete

>From 9730048908bbed0b9d3e205c09d3880eab29d6fe Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 7 Sep 2023 15:41:58 +0000
>Subject: [PATCH] Bug 34409: Fix inconsistencies in Audio alerts headers
>
>This patch makes a minor change to the structure of the audio alerts
>administration template so that the add/edit form is more consistent
>with other similar forms.
>
>The patch doesn't make any changes to page title and breadcrumbs because
>the add/edit action doesn't trigger a page reload, so the required
>change can't be made just with markup.
>
>To test, apply the patch and enable the AudioAlerts system preference
>if necessary.
>
>- Go to Administration -> Audio alerts.
>- Click "New alert" and confirm that the form looks correct.
>- Edit an existing alert to confirm that this view also looks correct.
>
>Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/modules/admin/audio_alerts.tt      | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
>index c25ac79024..80f36551d1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
>@@ -37,10 +37,11 @@
>                     <a class="btn btn-default" id="newalert" href="/cgi-bin/koha/admin/audio_alerts.pl"><i class="fa fa-plus"></i> New alert</a>
>                 </div>
> 
>+
>                 <form id="new-alert-form" action="audio_alerts.pl" method="post" class="validated">
>+                    <h1><span class="create-alert">New alert</span><span class="edit-alert">Edit alert</span></h1>
>                     <fieldset class="rows">
>-                        <legend><h1><span class="create-alert">Add new alert</span><span class="edit-alert">Edit alert</span></h1></legend>
>-
>+                        <legend class="sr-only">Audio alert details</legend>
>                         <input id="id" name="id" type="hidden" value="" />
>                         <ol>
>                             <li>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34409: 155336 | 155485 | 155486 | 155744