Bugzilla – Attachment 155754 Details for
Bug 34789
Fix typo in erm_eholdings_titles
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34789: (QA follow-up) Improve output of database update
Bug-34789-QA-follow-up-Improve-output-of-database-.patch (text/plain), 2.22 KB, created by
Katrin Fischer
on 2023-09-17 13:21:26 UTC
(
hide
)
Description:
Bug 34789: (QA follow-up) Improve output of database update
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-09-17 13:21:26 UTC
Size:
2.22 KB
patch
obsolete
>From 8ac6db43e778d21b9bc65df4a35f0efa5332d3e3 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 17 Sep 2023 13:18:49 +0000 >Subject: [PATCH] Bug 34789: (QA follow-up) Improve output of database update > >* Adds description >* Adds column names to success messages > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../data/mysql/atomicupdate/bug_34789-rename-column.pl | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_34789-rename-column.pl b/installer/data/mysql/atomicupdate/bug_34789-rename-column.pl >index f305f27ffa..196abd70c7 100755 >--- a/installer/data/mysql/atomicupdate/bug_34789-rename-column.pl >+++ b/installer/data/mysql/atomicupdate/bug_34789-rename-column.pl >@@ -2,7 +2,7 @@ use Modern::Perl; > > return { > bug_number => "34789", >- description => "A single line description", >+ description => "Correct datatypes and column name in table erm_eholdings_titles", > up => sub { > my ($args) = @_; > my ( $dbh, $out ) = @$args{qw(dbh out)}; >@@ -13,7 +13,7 @@ return { > ALTER TABLE erm_eholdings_titles RENAME COLUMN preceeding_publication_title_id TO preceding_publication_title_id > } > ); >- say $out 'Column renamed to preceding_publication_title_id'; >+ say $out 'Column preceeding_publication_title renamed to preceding_publication_title_id'; > } > if ( column_exists( 'erm_eholdings_titles', 'publication_title' ) ) { > $dbh->do( >@@ -21,7 +21,7 @@ return { > ALTER TABLE erm_eholdings_titles MODIFY COLUMN publication_title mediumtext > } > ); >- say $out 'Column datatype amended to mediumtext'; >+ say $out 'Column publication_title datatype amended to mediumtext'; > } > if ( column_exists( 'erm_eholdings_titles', 'notes' ) ) { > $dbh->do( >@@ -29,7 +29,7 @@ return { > ALTER TABLE erm_eholdings_titles MODIFY COLUMN notes mediumtext > } > ); >- say $out 'Column datatype amended to mediumtext'; >+ say $out 'Column notes datatype amended to mediumtext'; > } > }, > }; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34789
:
155607
|
155608
|
155609
|
155610
|
155730
|
155731
|
155732
|
155733
|
155750
|
155751
|
155752
|
155753
| 155754 |
155887