Attachment 155768 Details for Bug 34149 – Bug 34149: Let Syndetics images show when Amazon returns 1px images

[patch] Bug 34149: Let Syndetics images show when Amazon returns 1px images

Bug-34149-Let-Syndetics-images-show-when-Amazon-re.patch (text/plain), 1.93 KB, created by Victor Grousset/tuxayo on 2023-09-17 23:05:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2023-09-17 23:05:09 UTC

Size: 1.93 KB

patch

obsolete

>From bd802eee29738049d0be61c24a5716b48fcd5b94 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 10 Aug 2023 17:31:10 +0000
>Subject: [PATCH] Bug 34149: Let Syndetics images show when Amazon returns 1px
> images
>
>1. Turn on Syndetics (SyndeticsEnabled, SyndeticsCoverImages, SyndeticsClientCode)
>2. Set AmazonCoverImages and OPACAmazonCoverImages to show
>3. Go to a record detail page that has a Syndetics image but no Amazon image. In KTD I am using bib 181.
>     It might work and require to find another record.
>4. The image never loads.
>5. Do the same test on the OPAC, same result
>6. Apply patch
>7. Try again, the image should load.
>8. Try records that have both Amazon and Syndetics images making sure it loads correctly in the lightbox.
>9. Same last steps for OPAC
>
>Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index ffe3127816..80ad2ebfca 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -1509,6 +1509,9 @@
>                             }
>                         } else if ( div.attr("id") == "syndetics-bookcoverimg" ){
>                                 lightbox_descriptions.push(_("Syndetics cover image (<a href='%s'>see the original image</a>)").format($(img).data('link')));
>+                                if ( $('#amazon-bookcoverimg').length === 0 ) {
>+                                    div.show();
>+                                }
>                         }
>                         else if( div.hasClass("coce-coverimg" ) ){
>                             // Identify which service's image is being loaded by Coce
>-- 
>2.42.0

Actions: View | Diff | Splinter Review

Attachments on bug 34149: 154349 | 155551 | 155768 | 155769