Attachment 155793 Details for Bug 33828 – Bug 33828: ExportCircHistory description is misleading

[patch] Bug 33828: ExportCircHistory description is misleading

Bug-33828-ExportCircHistory-description-is-mislead.patch (text/plain), 2.05 KB, created by Martin Renvoize (ashimema) on 2023-09-18 10:40:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-09-18 10:40:32 UTC

Size: 2.05 KB

patch

obsolete

>From 8fd0d526df2e4bbe4ce4918041afd93047f1b762 Mon Sep 17 00:00:00 2001
>From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>Date: Thu, 22 Jun 2023 14:53:36 -0400
>Subject: [PATCH] Bug 33828: ExportCircHistory description is misleading
>
>This patch removes the mention of checkout history from the
>ExportCircHistory system preference description, as this system
>preference only allows to export current checkouts, not checkout
>history.
>
>This patch also modifies the description of the ExportRemoveFields
>system preference to also remove mention of checkout history.
>
>To test:
>0. Apply patch
>1. Go to Administration > System preferences > Circulation
>2. Read the description for ExportCircHistory, make sure it makes sense,
>   and that spelling and syntax are correct
>3. Read the description for ExportRemoveFields, make sure it makes
>   sense, and that spelling and syntax are correct
>
>Signed-off-by: Sam Lau <samalau@gmail.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/admin/preferences/circulation.pref        | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index 55feb4d4442..4ebc8b2c0c9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -140,9 +140,9 @@ Circulation:
>               choices:
>                   1: Show
>                   0: "Don't show"
>-            - the export patron checkout history options.
>+            - the option to export patron checkouts.
>         -
>-            - "The following fields should be excluded from the patron checkout history CSV or MARC (ISO 2709) export:"
>+            - "The following fields should be excluded from the patron checkout CSV or MARC (ISO 2709) export:"
>             - pref: ExportRemoveFields
>             - (separate fields with space, e.g. 100a 200b 300c).
>         -
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 33828: 152578 | 154221 | 155793