Attachment 155802 Details for Bug 32942 – Bug 32942: Suggestion API route when non 'standard' status are present

[patch] Bug 32942: Suggestion API route when non 'standard' status are present

Bug-32942-Suggestion-API-route-when-non-standard-s.patch (text/plain), 1.50 KB, created by Martin Renvoize (ashimema) on 2023-09-18 12:02:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-09-18 12:02:17 UTC

Size: 1.50 KB

patch

obsolete

>From ca5477da8ed39fb3d8224cfb20a78f1755f73edb Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr>
>Date: Fri, 10 Feb 2023 18:23:11 +0100
>Subject: [PATCH] Bug 32942: Suggestion API route when non 'standard' status
> are present
>
>The API route for listing all suggestion:
>
>/api/v1/suggestions
>
>send back an error message when there is a suugestion with non standard
>status (ASKED, CHECKED, ACCEPTED, REJECTED).
>
>This patch fixes this too restrictive restriction.
>
>TO TEST:
>
>1. Add a status in SUGGEST_STATUS AV list.
>2. Create a suggestion, and assign it to the previsous status.
>3. Call /api/v1/suggestion
>3. You get an error message:
>   {
>    "errors": [ {
>      "message":"Not in enum list: ASKED, CHECKED, ACCEPTED, REJECTED.",
>      "path":"\/1\/status"
>    }],
>    "status":200
>   }
>4. Apply the patch. Call /api/v1/suggestion
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> api/v1/swagger/definitions/suggestion.yaml | 5 -----
> 1 file changed, 5 deletions(-)
>
>diff --git a/api/v1/swagger/definitions/suggestion.yaml b/api/v1/swagger/definitions/suggestion.yaml
>index c0b4b584505..2056188772c 100644
>--- a/api/v1/swagger/definitions/suggestion.yaml
>+++ b/api/v1/swagger/definitions/suggestion.yaml
>@@ -65,11 +65,6 @@ properties:
>   status:
>     type: string
>     description: Suggestion status
>-    enum:
>-      - ASKED
>-      - CHECKED
>-      - ACCEPTED
>-      - REJECTED
>   note:
>     type:
>       - string
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 32942: 146508 | 146592 | 146593 | 146594 | 154642 | 154643 | 155801 | 155802 | 155803 | 155804 | 155805 | 155806 | 155900 | 155901 | 155902 | 155903 | 155904 | 155905 | 155906