Bugzilla – Attachment 155829 Details for
Bug 12532
Copy guarantee email to guarantor (or redirect if guarantee has no email set)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12532: (QA follow-up) Undo changes to Koha::Email
Bug-12532-QA-follow-up-Undo-changes-to-KohaEmail.patch (text/plain), 1.23 KB, created by
Martin Renvoize (ashimema)
on 2023-09-18 15:37:40 UTC
(
hide
)
Description:
Bug 12532: (QA follow-up) Undo changes to Koha::Email
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-09-18 15:37:40 UTC
Size:
1.23 KB
patch
obsolete
>From a5f12720e466e317e1419b707bfc0a8ed3ac6297 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 10 May 2023 18:11:52 +0100 >Subject: [PATCH] Bug 12532: (QA follow-up) Undo changes to Koha::Email > >The changes here aren't required (Email::Address already deals with >lists of addresses internally) > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Email.pm | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > >diff --git a/Koha/Email.pm b/Koha/Email.pm >index fa87b34735c..c7c23e3c1c6 100644 >--- a/Koha/Email.pm >+++ b/Koha/Email.pm >@@ -118,14 +118,10 @@ sub create { > $args->{to} = $params->{to}; > } > >- my @emails = split(',', $args->{to}); >- foreach my $email (@emails) { >- $email =~ s/ //g; >- Koha::Exceptions::BadParameter->throw( >- error => "Invalid 'to' parameter: ".$email, >- parameter => 'to' >- ) unless Koha::Email->is_valid($email); >- } >+ Koha::Exceptions::BadParameter->throw( >+ error => "Invalid 'to' parameter: " . $args->{to}, >+ parameter => 'to' >+ ) unless Koha::Email->is_valid( $args->{to} ); > > my $addresses = {}; > $addresses->{reply_to} = $params->{reply_to}; >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12532
:
29510
|
30747
|
35313
|
36752
|
39787
|
39925
|
48645
|
53649
|
53689
|
53690
|
53699
|
53700
|
55985
|
56052
|
56053
|
59445
|
59446
|
59447
|
63197
|
64802
|
64824
|
67115
|
68340
|
70865
|
72064
|
72617
|
75099
|
77606
|
80313
|
85134
|
85135
|
87815
|
87816
|
88208
|
88209
|
88210
|
88211
|
88212
|
88213
|
88295
|
88296
|
114455
|
114456
|
114457
|
114458
|
114459
|
114460
|
114461
|
131091
|
131092
|
131093
|
131094
|
149233
|
150071
|
150208
|
150217
|
150240
|
150256
|
151028
|
151029
|
154854
|
154855
|
154856
|
154857
|
155036
|
155037
|
155828
|
155829
|
155830
|
155831
|
155832
|
155833
|
155834
|
155835
|
155836
|
155837
|
155873
|
155874
|
155875
|
155876
|
155877
|
155878
|
155879
|
155880
|
155881
|
155882
|
155883
|
155886
|
155934
|
155935
|
155936
|
155937
|
155938
|
155939
|
155940
|
155941
|
155942
|
155943
|
155944
|
155945
|
155946