Attachment 155838 Details for Bug 34820 – Bug 34820: Clarify inventory tool message for items with non-matching notforloan value

[patch] Bug 34820: Clarify inventory tool message for items with non-matching notforloan value

Bug-34820-Clarify-inventory-tool-message-for-items.patch (text/plain), 2.49 KB, created by Kyle M Hall (khall) on 2023-09-18 16:08:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-09-18 16:08:41 UTC

Size: 2.49 KB

patch

obsolete

>From 295fcabac42627e52adf7caa854d330453c5d3b6 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 18 Sep 2023 12:02:34 -0400
>Subject: [PATCH] Bug 34820: Clarify inventory tool message for items with
> non-matching notforloan value
>
>In the inventory tool, if one or more not for loan values are selected, and an item is scanned that has no NFL status or an unselected NFL status, the error message reads "Unknown not-for-loan status". This can be interpreted as the item having an NFL status value that is not defined in the system, but that is not accurate. This should be reworded to remove ambiguity.
>
>Test plan:
>1) Create two items, one of which has the NFL status of "Ordered", the
> other having no NFL status
>2) Enter those two barcodes in the inventory tool barcodes list
>3) Check only "Ordered" in items.notforloan
>4) Note the problem messages
>5) Apply this patch
>6) Re-run the inventory tool
>7) Note the new clarified messages!
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>index a430a3fc248..d0fdf5f16f6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>@@ -149,6 +149,7 @@
> 
> <fieldset class="rows" id="optionalfilters">
> <legend>Optional filters for inventory list or comparing barcodes</legend>
>+ Scanned items are expected to match at least one of the critera.
> 
> <div id="statuses" style="display: block;">
> [% FOREACH status IN statuses %]
>@@ -311,7 +312,11 @@
> [% IF problem.key == 'wrongplace' %]
> Found in wrong place 
> [% ELSIF problem.key == 'changestatus' %]
>- Unknown not-for-loan status 
>+ [% IF result.notforloan %]
>+ Item has unselected Not for loan status [% result.notforloan %] 
>+ [% ELSE %]
>+ Items has no not for loan status 
>+ [% END %]
> [% ELSIF problem.key == 'not_scanned' %]
> Missing (not scanned) 
> [% ELSIF problem.key == 'checkedout' %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34820: 155838 | 155848 | 155849 | 155871 | 155928 | 155957 | 156499 | 156500 | 156501 | 156502