Attachment 155860 Details for Bug 34818 – Bug 34818: (bug 21083 follow-up) Fix batch patron modification tool

[patch] Bug 34818: (bug 21083 follow-up) Fix batch patron modification tool

Bug-34818-bug-21083-follow-up-Fix-batch-patron-mod.patch (text/plain), 1.29 KB, created by Katrin Fischer on 2023-09-18 19:32:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-09-18 19:32:09 UTC

Size: 1.29 KB

patch

obsolete

>From 0a61ea581a1766bf4ecc9cfe00f7e36a1a48774e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 18 Sep 2023 19:03:37 +0200
>Subject: [PATCH] Bug 34818: (bug 21083 follow-up) Fix batch patron
> modification tool
>
>It is not possible to perform batch patron modification without selecting
>a patron attribute
>
>Test plan:
>Test the batch patron modification tool, with or without extended
>attributes.
>
>The error was
>Can't call method "category_code" on an undefined value at /kohadevbox/koha/tools/modborrowers.pl line 407
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> tools/modborrowers.pl | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl
>index 2eb4dbf5af..36c893b416 100755
>--- a/tools/modborrowers.pl
>+++ b/tools/modborrowers.pl
>@@ -403,6 +403,9 @@ if ( $op eq 'do' ) {
> 
>         for my $code ( keys %$attributes ) {
>             my $attr_type = Koha::Patron::Attribute::Types->find($code);
>+
>+            next unless $attr_type;
>+
>             # If this borrower is not in the category of this attribute, we don't want to modify this attribute
>             next if $attr_type->category_code and $attr_type->category_code ne $patron->categorycode;
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34818: 155854 | 155859 | 155860